Project

General

Profile

Actions

Bug #18888

closed

Umlauts get displayed wrong in Web>Access module after updating rights

Added by Susanne Moog over 16 years ago. Updated about 16 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2008-06-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When updating user or group permissions inline in web>access -> permissions the umlauts are displayed wrong (see screenshot). If you change the module and then go back, everything is ok again. So it is saved correctly, only displayed wrong.

Reproduce:
- Make a group with an umlaut
- go to web>access
- choose "permissions" view
- click on the group of some page to change it immediately
- choose your umlaut group
- close editing form
- see problem
(issue imported from #M8578)


Files

accesslistumlaut-after1.png (5.42 KB) accesslistumlaut-after1.png Administrator Admin, 2008-06-01 18:42
accesslistumlaut-before.png (5.25 KB) accesslistumlaut-before.png Administrator Admin, 2008-06-01 18:42
accesslistumlaut-after2.png (6.83 KB) accesslistumlaut-after2.png Administrator Admin, 2008-06-01 18:42
patch_permajax_20080606_8578.diff (2.57 KB) patch_permajax_20080606_8578.diff Administrator Admin, 2008-06-06 09:43
patch_permajax_20080608_8578_b.diff (2.53 KB) patch_permajax_20080608_8578_b.diff Administrator Admin, 2008-06-08 20:05
patch_permajax_20080804_8578_d.diff (4.05 KB) patch_permajax_20080804_8578_d.diff Administrator Admin, 2008-08-04 21:13

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #18897: Umlauts get broken in shortcut menu while renaming the shortcutClosedBenni Mack2008-06-02

Actions
Actions #1

Updated by Tobias Liebig over 16 years ago

this is related to and should solved by #18897

Actions #2

Updated by Tobias Liebig over 16 years ago

patch attached

Summery:
Problem:
the posted values are utf-8-strings which are urlencoded (both encoding by prototype-js),
but the values are expected to be encoded like the backend is (iso-8859-1 by default)

Solution: 
convert the values after urldecoding
How to test:
- create a new BEuser and a new BEgroup
- use special chars in the name (like ä ö ü ß)
- goto web>access
- choose "permissions"
- change the owner and the group of a page
Note: the solution posted for #18897 (generally convert all post/get values) can't solve this issue, because the value is extra urlencoded and thus it can't be "utf8_decoded" before urldecoding
Actions #3

Updated by Tobias Liebig over 16 years ago

new, updated patch attached

Actions #4

Updated by Benni Mack over 16 years ago

Hey Tobias,

is this still valid / fixed? Can you send the patch to the core list?

Actions #5

Updated by Benni Mack over 16 years ago

Or was that fixed with #18897?

Actions #6

Updated by Susanne Moog over 16 years ago

it's still broken in current trunk

Actions #7

Updated by Tobias Liebig over 16 years ago

It was not fixed with #18897

i'd posted the patch on the corelist but right before 4.2.1 were released, benni and i decide to postpone this.
the latest patch in the corlist fixes the problem, but does not fix the reson.

if i remember right we came to this conclusion:

Currently the ajax call contains the user- or groupname. The PHP-Script need to convert the string twice(!):
in typo3ajax for alls _GET and _POST values and again in sc_mod_web_perm_ajax after URL-decoding
Then the Script send this string as ajax reponse to the client.
It's useless to send the username via Ajax to the server. The PHP script should read this from the database and return the value.

Thanks for reminding and taking care on this issue, Susanne!

I'll prepare a patch in the next days!

Actions #8

Updated by Tobias Liebig over 16 years ago

Can someone please remove the "pending in core list" tag

Actions #9

Updated by Tobias Liebig over 16 years ago

new patch attached.

now the javascript does not contain the username nor grouptitle and thus we go without the urldecode stuff on server side. Instead we read the username/grouptitle from the database and pass.

Actions #10

Updated by Tobias Liebig over 16 years ago

just posted to core list

Actions

Also available in: Atom PDF