Project

General

Profile

Actions

Bug #20307

closed

t3lib_cache_frontend_AbstractFrontend constructor is inefficient

Added by Dmitry Dulepov over 15 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2009-04-13
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The constructor of this class makes a copy of the passed object (t3lib_cache_backend_Backend). Copying happens two times: once the constructor is called and second time when internal member variable is assigned.

Both operations should use references to minimize memory usage.

(issue imported from #M10896)

Actions #1

Updated by Jochen Rau over 15 years ago

Since PHP 5 objects are passed by reference by default. You are using PHP 4.3 (??), but TYPO3 4.3 requires PHP >=5.2.0. IMO the existing code is o.k..

Actions #2

Updated by Oliver Hader about 15 years ago

Everything is fine here, $backend is an object and thus already a reference.

Actions #3

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF