Bug #20828
closed
Sorting icons are not redrawn
0%
Description
When trying to sort icons in IRRE enabled records via the sort buttons, the records are sorted, but the icons are not redrawn afterwards if one of the records was the first or the last one.
The problem comes from an invalid javascript statement in Prototype's findElements function. This function calls querySelectorAll() of the surrounding header element. Apparently, this function is broken in at least Firefox 3.5. It either throws an exception:
Exception ``[Exception... "An invalid or illegal string was specified" code: "12" nsresult: "0x8053000c (NS_ERROR_DOM_SYNTAX_ERR)" location: "http://typo3-dev/patchtest/typo3/contrib/prototype/prototype.js Line: 2844"]'' thrown from function onclick(event=MouseEvent:{0}) in <http://typo3-dev/patchtest/typo3/alt_doc.php?returnUrl=db_list.php%3Fid%3D28%26table%3D&edit[tx_irretutorial_1ncsv_hotel]1=edit> line 1.
or some Null exception.
The problem seems to be solvable by using headerObj.select() instead of Element.select(headerObj) in jsfunc.inline.js::redrawSortingButtons(). I'll further test this solution on different browsers and platforms.
(issue imported from #M11640)
Files
Updated by Andreas Wolf almost 15 years ago
The problem occurs on these platforms:
IE 7, WinXP
Firefox 3.5.1, WinXP
Opera 9.64, WinXP
Safari 4.0.1, MacOS X
Firefox 3.5.2, MacOS X
More to come ;) - especially older Firefox versions and IE 8.
Updated by Andreas Wolf almost 15 years ago
Firefox 2.0 Linux works
Firefox 3.0 Linux works
Firefox 3.5 Linux doesn't work
Opera 9.64 Linux works
Konqueror from KDE 4.2.2 does not work at all - but this is unrelated to this bug...
Updated by Andreas Wolf almost 15 years ago
Oops. Please ignore v1 of the patch. v2 contains the fix only for Firefox 3.5, all other browsers still use the old code. The problem is that the fix for FF 3.5 breaks FF 2.0, so we shouldn't change it in general, only for browsers where it makes sense (which is FF 3.5).
I'll do some further testing because I have changed a bit of the logic in the routine to make it easier to use the special case for FF 3.5.
Updated by Oliver Hader over 14 years ago
In which TYPO3 versions did you experience these kind of problems?
Updated by Andreas Wolf over 14 years ago
It also occurs in most recent trunk with FF 3.5 under WinXP SP2. I'll test it under Linux and OS X later today.
Updated by Andreas Wolf over 14 years ago
Most recent trunk under Mac OS X with FF 3.5.2 doesn't work either.
The problem generally exists with most browsers, but the proposed fix does break Firefox 3.5 upto 3.5.1 because of some weird javascript engine bug. If this doesn't matter, v1 of the patch does work, otherwise we should use v2. The JS bug has apparently been fixed in FF 3.5.2.
Updated by Alexander Opitz about 11 years ago
- Status changed from New to Needs Feedback
- Target version deleted (
0)
The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?
Updated by Alexander Opitz over 10 years ago
- Status changed from Needs Feedback to Closed
- Is Regression set to No
No feedback for over 90 days.