Project

General

Profile

Actions

Bug #21248

closed

"Clear temporary data" in setup module misses JS confirm

Added by Rupert Germann about 15 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2009-10-12
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Problem:
The new button "Clear temporary data" (data[clearSessionVars]) in user->setup has no JS confirm. The action is done immediately which can be very annoying because one has to re-set all prior settings (eg. the checkboxes and table collapse states in the list module)

Solution:
add a JS confirm like it is done in the "Reset Configuration and Clear Temporary Data" button.

(issue imported from #M12202)


Files

bug_12202.diff (1.96 KB) bug_12202.diff Administrator Admin, 2010-03-16 08:08
bug_12202_v3.diff (1.78 KB) bug_12202_v3.diff Administrator Admin, 2010-03-26 16:08
Actions #1

Updated by Soren Malling over 14 years ago

Having absolutely no idea, if the diff file is made correctly, I've attached a fix for the issue.

My very first patch so please be gentle to me ;-)

Added a confirm on the submit button and added a new language label

I also working on a patch for the error of the module showing "user settings saved" after hitting the "clear temporary data" instead of a message related to the temporary data being cleared

Actions #2

Updated by Chris topher over 14 years ago

Hi Søren,

your patch looks good!
One small change: Please use tab stopps to indent the new line in the locallang file.

To get your patch included, send it to the TYPO3-core-list!
Check out: http://typo3.org/teams/core/core-mailinglist-rules/

Actions #3

Updated by Francois Suter over 14 years ago

Committed attached v3 to trunk in revision 7181

v3 just adds minor CGLs changes (blanks around . operator) and adds "the" in the label for more proper English IMO.

Actions

Also available in: Atom PDF