Bug #21485

Multiple assigned classes in Text Style get lost in HTML cleaner.

Added by Schmidt Timo over 10 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2009-11-06
Due date:
% Done:

0%

TYPO3 Version:
4.3
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

  • Open the RTE
  • Create a paragraph and apply multiple text styles to a part of the paragraph.
  • During the saving process the classes get lost even if they are allowed.
  • The same seems to work for a complete paragraph.

I've figured out that there are two problems:

In the Method HTMLparserConfig the list of allowed
tags will be overwritten with an expoded string.

Line 1256 ad 1257:

if (strcmp($keepTags[$key]['fixAttrib'][$atName]['range'],'')) $keepTags[$key]['fixAttrib'][$atName]['range'] = t3lib_div::trimExplode(',',$keepTags[$key]['fixAttrib'][$atName]['range']);
if (strcmp($keepTags[$key]['fixAttrib'][$atName]['list'],'')) $keepTags[$key]['fixAttrib'][$atName]['list'] = t3lib_div::trimExplode(',',$keepTags[$key]['fixAttrib'][$atName]['list']);

But at runtime $keepTags[$key]['fixAttrib'][$atName]['range'] contains an array, not a string. Therefor The Sting "Array" is afterwards content of $keepTags[$key]['fixAttrib'][$atName]['list'].

In my opinion we need to check first if the value is realy a string and if
not, we shouln't do anything:

Second Problem:

In the method HTMLcleaner the handling of a list need to be enhanced to allow the user to use MultipleListItems. To solve this i've introduced an configuration option "allowMultipleListItems"

(issue imported from #M12496)

class.t3lib_parsehtml.php.patch View (2.4 KB) Administrator Admin, 2009-11-06 16:49


Related issues

Duplicates TYPO3 Core - Bug #22900: Span tags with multiple classes being removed Closed 2010-06-16

History

#1 Updated by Schmidt Timo over 10 years ago

Option to allow multiple css classes is:

proc.HTMLparser_db.tags.span.fixAttrib.class.allowMultipleListItems = 1

#2 Updated by Stanislas Rolland almost 9 years ago

  • Category set to RTE (rtehtmlarea + ckeditor)
  • Target version deleted (0)
  • TYPO3 Version set to 4.3

#3 Updated by Stanislas Rolland over 8 years ago

This issue was solved in TYPO3 4.3.5 in a different way.

The class attribute is treated in a different way when the list property is used: only classes not in the specified list are removed.

See: http://forge.typo3.org/projects/typo3v4-core/repository/revisions/ce2df03d31aa70bae4971d6cb3a8260c605a0e1b

#4 Updated by Stanislas Rolland over 8 years ago

  • Status changed from New to Resolved
  • Assignee set to Stanislas Rolland

#5 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF