Project

General

Profile

Actions

Bug #22037

closed

mod.web_list.hideTables does not accept spaces

Added by Calderini Daniel about 14 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2010-02-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you enter the following config in the page tsconfig, table tt_content will be hidden, but not tt_news :
mod.web_list.hideTables = tt_content, tt_news

This is due to the space after the comma. If you remove the space, both tables will be hidden.

(issue imported from #M13386)


Files

typo3.13386.patch (1.45 KB) typo3.13386.patch Administrator Admin, 2010-02-15 15:58
13386_04.diff (1.26 KB) 13386_04.diff Administrator Admin, 2010-03-26 14:14
Actions #1

Updated by Chris topher about 14 years ago

Since it works correctly without the space, I don't see a problem here.
This is a "comma seperated list" and seperation with comma works as expected.

Actions #2

Updated by Calderini Daniel about 14 years ago

You're right, it works as expected. But it is a bit inconsistent with other options.

For example:
mod.web_list.allowedNewTables
mod.web_list.deniedNewTables

Both accept spaces between table names, even if the data type is the same as hideTables (list of tablenames).
So maybe it just needs to be written in doc_core_tsconfig that spaces are not allowed...

Actions #3

Updated by Marcel Greter about 14 years ago

IMO whitespace should be allowed as one might want to write something like that:

mod.web_list.hideTables (
tx_extension_table1,
tx_extension_table2,
tx_extension_table3,
tx_extension_table4,
...
)

Actions #4

Updated by Georg Ringer about 14 years ago

problem is not the hideTables but t3lib_div::inList which doesn't work with spaces in comma seperated lists

Actions #5

Updated by Marcel Greter about 14 years ago

Is there a reason not to use t3lib_div::trimExplode and in_array as it is with allowedNewTables and deniedNewTables? IMO I don't see any (actually I think it should have been that way from the start)?

I posted a patch as the necessary changes are very small and easy to do.

Actions #6

Updated by Benni Mack about 14 years ago

Hey Marcel.

Care to send this to the TYPO3 core list?

http://typo3.org/teams/core/core-mailinglist-rules/

Actions #7

Updated by Marcel Greter about 14 years ago

Hi Benjamin,

I did submit it to the list on March 8, but did not receive any feedback at all.

Best wishes, Marcel

Actions #8

Updated by Christian Kuhn about 14 years ago

Hey Marcel, I just reviewed your patch in the core list. Thank for your patience.

Actions #9

Updated by Christian Kuhn about 14 years ago

Committed to trunk rev. 7173

Actions #10

Updated by Christian Kuhn about 14 years ago

Committed to 4.3 rev. 7428

Actions

Also available in: Atom PDF