Bug #22105
closed
Function changePassword does not work, when hitting 'enter' in change password form
0%
Description
When trying to send the change password form by hitting 'enter' in the frontend, the same form appears again and again. It works only, when clicking on the submit button.
The method tx_felogin_pi1->changePassword() checks the _POST value 'changepasswordsubmit' (generated by the submit button) only with if ($postData['changepasswordsubmit'])).
When a form was sent without a mouse click, the value of the field will be '0' and thus not recognized.
checking with isset() will resolve this.
TYPO3 version 4.3.1
felogin version 1.3.0
(issue imported from #M13506)
Files
Updated by Steffen Müller almost 15 years ago
The relevant form field in the template is:
<input type="submit" name="tx_felogin_pi1[changepasswordsubmit]" value="###SEND_PASSWORD###" />
I guess your problem appears when ###SEND_PASSWORD### is not set (no button text). IMHO this should not be the case in practice.
Anyway your patch looks ok, since it would make the check more bulletproof. You can give it a try and send a RFC to the core list: http://typo3.org/teams/core/core-mailinglist-rules/
Note to self: PHP type comparison can be found here: http://www.php.net/manual/de/types.comparisons.php
Updated by Christian Futterlieb over 14 years ago
I detected the problem because I used an input with type="image" and the ###SEND_PASSWORD### marker is only in the 'alt' attribute (would have been a good idea to tell that before, sorry).
I'll submit a RFC, thanks for the hint
Updated by Christian Kuhn over 14 years ago
Committed to trunk rev. 7797, 4.3 rev. 7798
Updated by