Bug #22136
closed
Popup-functionality for Pages using target field don't work in IE
100%
Description
If I use the target field for pages to open a popup-window, the IE (all versions) opens a wrong URL (e.g. http://domain.de/en/page1/page1_1/en/page1/page1_1/). I think the problem in TYPO3 is that no baseurl is prepended the url.
If I replace the line 1276 in the file "class.tslib_menu.php"
$onClick = 'vHWin=window.open(\'' . $LD['totalURL'] . '\',\'FEopenLink\',\'' . $JSparamWH . '\');vHWin.focus();return false;';
with
$onClick = 'vHWin=window.open(\'' . $GLOBALS['TSFE']->baseUrlWrap($LD['totalURL']) . '\',\'FEopenLink\',\'' . $JSparamWH . '\');vHWin.focus();return false;';
all works fine.
I have found this solution in the file "class.tslib_content.php" on line 6205. In this file baseUrlWrap() is used to wrap the url.
It seems, that this IE problem was already reported to Microsoft, but unfortunately, not fixed yet.
http://connect.microsoft.com/VisualStudio/feedback/details/449388/base-href-is-ignored-for-shortcut-icon-window-open-and-window-location-href
(issue imported from #M13575)
Updated by Oliver Hader almost 15 years ago
I guess that this behaviour also occurs in TYPO3 4.2.x, doesn't it?
Updated by Dirk Eidam almost 15 years ago
I think this is a new feature in TYPO3 4.3
RELEASE NOTES FOR TYPO3 4.3:
2009-07-16 Steffen Kamper <info@sk-typo3.de>
* Added feature #19625: Popup-functionality for Pages using target field
Updated by Benjamin Strilziw almost 14 years ago
The problem does still exist in 4.4.x (I guess, found in 4.4.4 and 4.4.6). The Internet Explorer won't open Popups correctly with the line
$onClick = 'vHWin=window.open(\'' . $LD['totalURL'] . '\',\'FEopenLink\',\'' . $JSparamWH . '\');vHWin.focus();return false;';
Updated by Alexander Opitz over 11 years ago
- Category deleted (
Communication) - Status changed from New to Needs Feedback
- Target version deleted (
-1)
The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?
Updated by Hannes no-lastname-given over 11 years ago
Just noticed it in 4.5.27 (and it was there in 4.5.26 too)
Same solution helps, but it is on line 1312 in 4.5.27
Updated by Alexander Opitz over 11 years ago
- Status changed from Needs Feedback to Accepted
- Assignee set to Alexander Opitz
Updated by Gerrit Code Review over 11 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23227
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23227
Updated by Gerrit Code Review about 11 years ago
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25284
Updated by Gerrit Code Review about 11 years ago
Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25285
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25284
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25285
Updated by Alexander Opitz about 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 3158cffec83240dac864ae85d471dcb06cca4cd0.
Updated by