Feature #22169

ext_typoscript_setup.txt cannot be overriden by static files on the same level

Added by Fabrizio Branca almost 10 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2010-02-23
Due date:
% Done:

100%

PHP Version:
5.2
Tags:
Complexity:
Sprint Focus:

Description

Problem:
Some extension still deliver ext_typoscript_setup.txt (amongst them some popular ones like templavoila and new ones like felogin...). In the sys_template record you can choose
- whether to not include them at all (Never include before this template record)
- whether to always include them
- or to include them only if the template is a root template.
In any case (when include) the templates will be included after the static ones and the static ones from extensions. This makes it impossible to override settings there from within a static template (without having a second template on the next level)

Solution:
Offer a new option that includes those templates if the Root-Flag is set, but includes them before all other templates (so you can overwrite them).

Notes:
Apply the patch, install an extension with ext_typoscript_setup.txt and tehn have a look at the order of templates in the template analyzer with the different options.

(issue imported from #M13634)

13634 .diff View (4.41 KB) Administrator Admin, 2010-02-23 16:55


Related issues

Related to TYPO3 Core - Bug #38104: Remove bogus template in template analyzer Closed 2012-06-15
Related to TYPO3 Core - Task #52364: Repeated use of 8-year-deprecated feature ext_typoscript_setup.txt in core extensions Rejected 2013-09-29

Associated revisions

Revision ac8e8128 (diff)
Added by Tolleiv Nietsch over 8 years ago

[FEATURE] Allow overriding ext_typoscript_setup.txt on same level

Change-Id: I3f28f9cb3efb46598fcc46c450cec05f94454e97
Resolves: #22169
Releases: 4.6
Reviewed-on: http://review.typo3.org/3009
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper

History

#1 Updated by Popy no-lastname-given almost 10 years ago

+1 on reading !

From my point of view, things that are loaded by default (means: without any manul action, like selecting a static) should be loaded BEFORE things that are manually included, in order to be able to override default things by a choosen thing :)

#2 Updated by Stefan Geith over 9 years ago

I think, there should be an option in ext_emconf.php, to let each plugin decide, if it wants to have ext_typoscript_setup.txt included before or after static templates.

It could break existing plugins, if ext_typoscript_setup.txt is include before static templates, if this is not provided by the plugin.

E.g.: some of my plugins set a special constant in their staitc templates. If none of these is static templates is loaded (special constant is not set) then I include some default-template in ext_typoscript_setup.txt by TS conditions.

#3 Updated by Popy no-lastname-given about 9 years ago

-1 finally :( (i should have posted this earlier, sorry for that)

My point of view is still "I don't want to use static for default typoscript", but including ext_typoscript_setup.txt before statics result in problems for plugin declaration (throught t3lib_extMgm::addPiTost43), because their base typoscript is added at the end of CSS Styled content static.

BUT there is an alternative solution : adding default typoscript (and why not ext_typoscript_setup) AFTER the CSS Styled content static. By doing this their is no more compat problem and the TS is overridable by other statics (it is not a supposition, i'm including default typoscript this way in my own extensions since 6 monthes now).

The best solution (IMO) is to provide a new way to add default typoscript (I can attach some patch/code if needed, as I've already done this) wich adds this TS after the CSS Styled content static.

For ext_typoscript_setup.txt files, we'll have the choice between keeping the current bahaviour or automatically adding it throught the new way

#4 Updated by Mr. Hudson over 8 years ago

Patch set 1 of change I3f28f9cb3efb46598fcc46c450cec05f94454e97 has been pushed to the review server.
It is available at http://review.typo3.org/3009

#5 Updated by Mr. Hudson over 8 years ago

Patch set 2 of change I3f28f9cb3efb46598fcc46c450cec05f94454e97 has been pushed to the review server.
It is available at http://review.typo3.org/3009

#6 Updated by Mr. Hudson over 8 years ago

Patch set 3 of change I3f28f9cb3efb46598fcc46c450cec05f94454e97 has been pushed to the review server.
It is available at http://review.typo3.org/3009

#7 Updated by Mr. Hudson over 8 years ago

Patch set 4 of change I3f28f9cb3efb46598fcc46c450cec05f94454e97 has been pushed to the review server.
It is available at http://review.typo3.org/3009

#8 Updated by Mr. Hudson over 8 years ago

Patch set 5 of change I3f28f9cb3efb46598fcc46c450cec05f94454e97 has been pushed to the review server.
It is available at http://review.typo3.org/3009

#9 Updated by Mr. Hudson over 8 years ago

Patch set 6 of change I3f28f9cb3efb46598fcc46c450cec05f94454e97 has been pushed to the review server.
It is available at http://review.typo3.org/3009

#10 Updated by Tolleiv Nietsch over 8 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#11 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF