Project

General

Profile

Actions
Copy link

Bug #22397

closed

Cleanup: class.t3lib_userauthgroup.php

Added by Not Only Pixel over 14 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2010-04-07
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.4
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

1. added missing spaces according to CGL
2. replaced one while(list)=each with a foreach
3. replaced one "true" to TRUE
4. renamed some variables for better naming and understanding

(issue imported from #M14028)

Files

Download all files
patch.diff (531 Bytes) patch.diff Administrator Admin, 2010-04-07 15:46
14028_variables.diff (2.11 KB) 14028_variables.diff Administrator Admin, 2010-04-07 18:01
14028_CGL.diff (62.9 KB) 14028_CGL.diff Administrator Admin, 2010-04-07 18:01
14028_foreach.diff (640 Bytes) 14028_foreach.diff Administrator Admin, 2010-04-07 18:02
14028_variables_v2.diff (3.72 KB) 14028_variables_v2.diff Administrator Admin, 2010-04-21 10:37
14028_foreach_take2.patch (575 Bytes) 14028_foreach_take2.patch Administrator Admin, 2010-05-06 21:43
14028_variables_take3.patch (3.74 KB) 14028_variables_take3.patch Administrator Admin, 2010-05-06 21:43
14028_CGLv2.diff (67.5 KB) 14028_CGLv2.diff Administrator Admin, 2010-05-07 10:35
14028_CGLv3.diff (73.6 KB) 14028_CGLv3.diff Administrator Admin, 2010-05-07 18:26
Actions
Copy link
 #1

Updated by Dmitry Dulepov over 14 years ago

14028_v2 refactors some names even more, makes a single return from the function (as requested by CGL) and fixes wrong @access.

Actions
Copy link
 #2

Updated by Benni Mack over 14 years ago

Part 1 (variables and foreach) commited to trunk (rev. 7555). The CGL patch doesn't apply anymore.

Actions
Copy link
 #3

Updated by Not Only Pixel over 14 years ago

Updated CGL patch to version 2

Actions
Copy link
 #4

Updated by Not Only Pixel over 14 years ago

attached version 3, replace a lot of return statements according to CGL

Actions
Copy link
 #5

Updated by Alexander Opitz over 11 years ago

  • Status changed from New to Needs Feedback
  • Target version deleted (0)

The issue is very old, is something left over from this changes in newer TYPO3 CMS versions?

Actions
Copy link
 #6

Updated by Alexander Opitz about 11 years ago

  • Status changed from Needs Feedback to Closed
  • Is Regression set to No

No feedback for over 90 days.

Actions
Copy link

Also available in: Atom PDF