TYPO3 Core

After having finally found what was wrong with the error handler, I could go further in the process and noticed another issue.

The call to t3lib_install::writeToLocalconf_control() may fail not only when localconf.php is not writable, but also when the folder "typo3conf" is not writable, because the method tries to write a temporary file first, when changes are made.

So the second call to t3lib_install::writeToLocalconf_control() should check the return value, which is "nochange" if writing failed. Here's another very rough patch of the kind of correction that must be made:

$result = $instObj->writeToLocalconf_control($lines);
if ($result === 'nochange') {
echo 'DBAL not loaded';
}

Without this, the loading of DBAL will fail silently and the user will never be given the choice to choose another DBMS. This is particularly critical because - up to that point - the user trying to install TYPO3 has not been told that typo3conf should be writable.

Committed 14274.diff to:

- DBAL trunk (rev. 32847)
- DBAL_1-1 (rev. 32848)

Thanks Francois.

Hmm, looking at the diff for revision 32847, you don't seem to have taken my second remark into account.

If you just keep calling:

$instObj->writeToLocalconf_control($lines);

without checking the result, you will fail catching that writing to the localconf.php may have failed and that DBAL is not actually loaded.

Hi Francois,

I agree with second point. Having a look at the problem...

Committed follow-up to

- DBAL trunk (rev. 33343)
- DBAL_1-1 (rev. 33344)

Now throws an exception if typo3conf is not writable which is catched and outputs a pretty error box:

Error

DBAL was not loaded. /Users/xavier/Sites/typo3dev.loc/mysql2/typo3conf/ is not writable!