Project

General

Profile

Actions

Bug #22784

closed

Width of one paragraph of text in the Install Tool is too big

Added by Jonathan Starck over 14 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2010-06-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.4
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The text goes over the edge in the paragraph "[pageUnavailable_handling]"

Reproducable:
1. Login in to the Install Tool
2. Go to "All Configuration"
3. Jump to "[pageUnavailable_handling]"

(issue imported from #M14564)


Files

bug_14564.diff (1.06 KB) bug_14564.diff Administrator Admin, 2010-11-03 22:55

Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Feature #22423: Install tool refactoringClosedPatrick Broens2010-04-11

Actions
Related to TYPO3 Core - Bug #22975: PATH_thisScript in the Install Tool, Basic Configuration should have line breakClosedChris topher2010-06-23

Actions
Has duplicate TYPO3 Core - Bug #23931: Description of pageUnavailable_handling breaks layout under FFClosedChris topher2010-11-03

Actions
Actions #1

Updated by Chris topher over 14 years ago

This is still an issue.
Interestingly it works correctly for (most?) other sections on that screen, but not for this one (although the sourcecode is basically the same...).

Actions #2

Updated by Chris topher over 14 years ago

I just checked that: It works correctly for all(!) other sections. This is the only one with that problem.

Actions #3

Updated by Andy Grunwald over 14 years ago

The Problem is the String "USER_FUNCTION:typo3conf/pageUnavailableHandling.php:user_pageUnavailable->pageUnavailable" whoch could not be breaked by the browser.

Actions #4

Updated by Chris topher over 14 years ago

So a simple space behind the "->" would fix that. A nobrainer in the end...

Actions #5

Updated by Chris topher over 14 years ago

Or even better: Adding the CSS definition

word-wrap: break-word;

can fix that.

Actions #6

Updated by Marc Wöhlken about 14 years ago

@christopher:
Is word-wrap really part of the css standard? AFAIK it's an IE invention and obviously does not work under Firefox...

Just tried adding "word-wrap: break-word; white-space: -moz-pre-wrap;" to the li-elements which worked fine.

Would it be appropriate to use such mozilla specific settings?!

Actions #7

Updated by Chris topher about 14 years ago

word-wrap only is part of CSS3 I think. So, it is not yet a standard, but I read that it already should work in Firefox.
But the moz... property you propose is no standard either, is it? ;) Doesn't it work without that?

Actions #8

Updated by Marc Wöhlken about 14 years ago

"word-wrap: break-word" seems not to word under FF 3.6.x.

Actions #9

Updated by Chris topher about 14 years ago

OK.

Just take the solution you like best!
The same problem is there at 2 other places in the same file:
- The line displaying PATH_thisScript in Basic Configuration and
- The same line in the part "Clean up"
Would be great if you could fix that the same way then!

Actions #10

Updated by Marc Wöhlken about 14 years ago

Added a patch to solve this issue:
- added new class t3-install-description to "All configuration page"
- formatted that class: word-wrap: break-word; width: 48em;

@christoph -: word-wrap works in FF when the element has a defined width.

Actions #11

Updated by Marc Wöhlken about 14 years ago

The same problem is there at 2 other places in the same file:
- The line displaying PATH_thisScript in Basic Configuration and

Works fine in TYPO3 4.4 / 4.5 under FF & IE8. Any info on which browsers have to be used to reproduce the problem?

- The same line in the part "Clean up"

Could not see where this problem arises.

Actions #12

Updated by Chris topher about 14 years ago

- The line displaying PATH_thisScript in Basic Configuration

Indeed! I just saw the screenshot
http://bugs.typo3.org/file_download.php?file_id=11892&type=bug
which is attached to #22975.
I just noticed: For me a path, which would be too long, is broken at a "-" sign in the path. And paths without such a "-" are broken at the slash next to the border of the div box. Great!

- The same line in the part "Clean up"

Yes, sorry for the inconvenience. Seems like this line was removed since I last checked that.

Actions #13

Updated by Marc Wöhlken about 14 years ago

This works even when there is no "-" in the path. In my installation the word "pageUnavailable" gets split up across lines.

Actions #14

Updated by Chris topher about 14 years ago

Your patch works and solves the problem!

Send it to Core List!

Actions #15

Updated by Marc Wöhlken about 14 years ago

Patch is submitted to core list, give it a +1 if you like the solution.

Actions #16

Updated by Steffen Gebert almost 14 years ago

Committed to trunk rev. 9816.
Thanks for your contribution, Marc!

Actions #17

Updated by Susanne Moog over 13 years ago

  • Target version deleted (4.5.0)
Actions

Also available in: Atom PDF