Bug #23103: It is not possible to search for '%' or '_' inside the Backend - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #23103

closed

It is not possible to search for '%' or '_' inside the Backend

Added by Caspar Stuebs over 14 years ago. Updated over 10 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Database API (Doctrine DBAL)

Target version:

Start date:

2010-07-05

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.4

PHP Version:

5.2

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Neither with the search-button in the Backend-Toolbar, nor within the Admin-Tool 'DB check' with the 'full search' function, it is possible to search for the chars '%' and '_'.

Both functions does not escape the named chars for using inside the like-query, so they are interpreted as wildcards by sql.

Additionally the Toolbar-search does not use the function t3lib_db->searchQuery, which should be used for dbal support.

Solution:
adding t3lib_db->escapeStrForLike into t3lib_db->searchQuery
using t3lib_db->searchQuery inside the Toolbar-search (class.db_list.inc)

see patch
(issue imported from #M15001)

Files

Download all files

bug_15001.patch (1.24 KB) bug_15001.patch		Administrator Admin, 2010-07-05 00:29
15001_core_v3.diff (2.34 KB) 15001_core_v3.diff		Administrator Admin, 2010-07-20 07:57
15001_dbal_v4.diff (12.4 KB) 15001_dbal_v4.diff		Administrator Admin, 2010-07-20 07:57
15001_dbal_v5.diff (12.4 KB) 15001_dbal_v5.diff		Administrator Admin, 2010-08-12 01:18

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Xavier Perseguers over 14 years ago

Just uploaded 15001_core_v3.diff (from mailing list) and a new version of DBAL's patch (15001_dbal_v4.diff) which does not exist in ML but works at least with unit tests. Will have to test it on real DBMS.

Actions

Copy link

Updated by Caspar Stuebs over 14 years ago

Uploaded a new version of DBAL's patch (15001_dbal_v5.diff)

searchQuery() should only add the ' OR ' to the query, if both parts contains data, not only the first one...

Actions

Copy link

Updated by Xavier Perseguers over 14 years ago

Hi,

Thanks for the patch. After testing, I found a bug. Search is issed on all columns regardless of their type. In particular:

SELECT COUNT FROM "sys_language" WHERE "pid" IN (22,23,0) AND ((dbms_lob.instr("uid", 'page',1,1) > 0) OR (dbms_lob.instr("title", 'page',1,1) > 0))

This makes the query crash with Oracle as search for 'page' in column "uid" is incorrect. MySQL silently allows this but it does not make sense. As such, patch should be enhanced to search for non-numeric content only on non-numeric columns

Actions

Copy link