Project

General

Profile

Actions

Bug #23205

closed

Inconsistent icon usage for Page Properties

Added by Henrik Ziegenhain over 14 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2010-07-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Between page and list module is a small inconsistent usage of the icon for the page properties.

I think in terms of Usability this should be fixed.

How to test:
1. go to page module
2. look at the icon for page properties (sheet with pencil)
3. go to list module
4. look also at the page properties icon (only the old yellow pencil)

Or just take a look at the attached screenshot :)

(issue imported from #M15147)


Files

page_properties.png (2.36 KB) page_properties.png Administrator Admin, 2010-07-16 10:24
page_properties_v2.png (2.38 KB) page_properties_v2.png Administrator Admin, 2010-07-16 12:05
15147-page-props-icon.patch (692 Bytes) 15147-page-props-icon.patch Administrator Admin, 2010-07-16 12:16
15147-pageproperties-v2.patch (1.41 KB) 15147-pageproperties-v2.patch Administrator Admin, 2010-07-27 15:10
Actions #1

Updated by Georg Ringer over 14 years ago

also the sorting is a bit mixed up

Actions #2

Updated by Henrik Ziegenhain over 14 years ago

Hi Georg,

damn you`re right. I made the screens and overlooked this...
Would be nice to see the same order.

Attached screen v2.

Actions #3

Updated by Georg Ringer over 14 years ago

i will make a patch next week, don't have time now. just for a reminder or if someone else is faster:

page view > /typo3/sysext/cms/layout/db_layout.php > 1207
list view > /typo3/class.db_list_extra.inc > 207

Actions #4

Updated by Henrik Ziegenhain over 14 years ago

Thanks 4 the hint.

Switching to the correct Icon in list was easy :)
But does someone excepct Georg know how to change the order of icons?

Just changing the order in the array to doesn`t work:
$buttons = array(
..
'move' => '',
'hide_unhide' => '',
..
)

Debug (sad I already how cool the new debug console is?) prints out the correct new order. Strange.

Edit:
oh... there is ja already a patch for the wrong icon. Thanks Georg

Actions #5

Updated by Henrik Ziegenhain over 14 years ago

Sorry, now I searched for over an hour how to change the order of icons.

It seemed to be an easy job, but I didn`t find the correct piece of code. Where are the core-devs? :)

Actions #6

Updated by Georg Ringer over 14 years ago

will provide a patch tomorrow

Actions #7

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF