Bug #23512
closed
Browsebox broken since 4.3.x?
0%
Description
When searches return more hits than $results_at_a_time, the links presented for additional pages of results are broken.
Reason: class.tx_indexedsearch.php:makePointerSelect_link() uses getElementById to find the hidden form elements to update, but the form elements doesn't have any id attributes, only name attributes.
Solution: Either add id attributes to the form elements (add ###HIDDEN_FIELDID### in makeSearchForm() ?) or use getElementsByName in makePointerSelect_link().
This came up during upgrade of a couple of installations from 4.2.x --> 4.3.5. The same code seems to be in 4.4.2.
I've tried it with the original css-template for indexed_search, as well as a modified one.
(issue imported from #M15656)
Files
Updated by Mattias Borell over 13 years ago
Oops, sorry, this seems to have been reported already... My bad.
Updated by Steffen Gebert over 13 years ago
where? please give us the bug number and we can close this report.
IIRC you need to adjust your template (or use the new version) - some ID or so changed...
Updated by Mattias Borell over 13 years ago
The issue is mentioned in 0015597 and 0014130.
The easiest solution would be to add the proper id's to the two affected form elements in the template file. They are missing in the stock template file that came with 4.4.2, but if I understand the report concerning 0014130 correctly, a patch has been added to the tree.
Updated by over 13 years ago
@Steffen: Xavier's solution in #14130 works fine.
The problem is that the corrections were only made in the outdated indexed_search.tmpl and not in template_css.tmpl.
Attached is a patch for template_css.tmpl, I will make a RFC.
Updated by Xavier Perseguers over 13 years ago
Committed to:
- trunk (rev. 9274)
- 4-4 (rev. 9275)
- 4-3 (rev. 9276)
Updated by