Bug #24218
closedRefactor conditions in t3lib_extFileFunc
100%
Description
t3lib_extFileFunc has a lot of deeply nested conditions. These conditions make understanding the code really hard.
Most of the else-branches only contain a log call, so it helps a lot to invert the conditions and move the log call inside the if-branch. The else branch can then be removed, the code can be streamlined.
Example:
before:
if (condition) {
foo();
bar();
} else {
$this->writeLog(...);
}
after:
if (!condition) {
$this->writeLog(...);
}
foo();
bar();
(issue imported from #M16586)
Files
Updated by Andreas Wolf over 13 years ago
Attached a patch with the suggested refactorings.
Updated by Mr. Hudson almost 13 years ago
Patch set 2 of change Ic900fe3294142ebc89be4c3d420bb729a24d5452 has been pushed to the review server.
It is available at http://review.typo3.org/1087
Updated by Andreas Wolf almost 13 years ago
- Status changed from New to Resolved
- Target version changed from 0 to 1238
- % Done changed from 0 to 100
- TYPO3 Version changed from 4.5 to 4.6
Has been integrated with commit 2585d5a060eb1196965458954b30d0b869abc58c.
Updated by Xavier Perseguers about 12 years ago
- Status changed from Resolved to Closed