Bug #24370: Generating preview link not working since Update to 4.4.5 - TYPO3 Core - TYPO3 Forge

Actions

Bug #24370

closed

Generating preview link not working since Update to 4.4.5

Added by Frederic Gaus over 13 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

-

Target version:

-

Start date:

2010-12-20

Due date:

% Done:

0%

Estimated time:

TYPO3 Version:

4.4

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Since our update to Version 4.4.5 (which is currently not chooseable in the bugtracker) generating preview-links is not working.

The Problem is caused by the call of t3lib_BEfunc::getViewDomain() instead of t3lib_div::getIndpEnv('TYPO3_SITE_URL'). The API says:

Returns:
string the full domain including the protocol http:// or https://, but without the trailing '/'

This trailing '/' is missing in the preview-link. I attached a patch.

How to test
Choose modul "Versioning" and click the button "Preivew-Link". Click on the generated link.

(issue imported from #M16786)

Files

Download all files

patch-v1.diff (1.02 KB) patch-v1.diff		Administrator Admin, 2010-12-20 10:45
bug_16786.diff (1.78 KB) bug_16786.diff		Administrator Admin, 2010-12-20 11:03
16786_v3.diff (2.84 KB) 16786_v3.diff		Administrator Admin, 2010-12-21 10:27
16786_trunk.diff (1.52 KB) 16786_trunk.diff		Administrator Admin, 2010-12-21 22:17

Related issues 1 (0 open — 1 closed)

Actions

#1

Updated by Frederic Gaus over 13 years ago

Attached unified diff

Actions

#2

Updated by Francois Suter over 13 years ago

This is a regression introduced by the fix to 0009508.

Actions

#3

Updated by Francois Suter over 13 years ago

Committed v3 to 4.4 in revision 9870 and trunk (to be on the safe side) in revision 9871.

NOTE 1: typo3/mod/user/ws/index.php does not exist in trunk anymore.

NOTE 2: the "Fixed in Version" value should really be 4.4.6, but this choice is not available yet.

Actions

#4

Updated by Benni Mack over 5 years ago

Status changed from Resolved to Closed

Actions

Also available in: Atom PDF