Bug #24479
closed
Two link elements created for favicon
100%
Description
Lines 80 and 81 of class.t3lib_pagerenderer.php define two link tags for the favicon:
protected $shortcutTag = '<link rel="shortcut icon" href="%1$s"%2$s />
<link rel="icon" href="%1$s"%2$s />';
According to the HTML standard rel="icon" would be correct but IE needs rel="shortcut icon". However, there's no reason to repeat the link. The value of the rel attribute will be split on spaces and then parsed. So standards-compliant browsers will understand rel="shortcut icon" correctly.
(issue imported from #M16921)
Updated by Alexander Opitz over 10 years ago
- Status changed from New to Needs Feedback
- Target version deleted (
0) - TYPO3 Version set to 4.5
- Is Regression set to No
Hi,
as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.2.3)?
Updated by Stephan Bauer about 10 years ago
Yes. Would be great if this could be fixed.
Another question: Is there a need to have an absolute link? I think it would be better to have it only relative.
I have a problem with that on a site where I have to use 'recursiveDomainSearch' and https.
Updated by Stephan Bauer about 10 years ago
More information:
http://en.wikipedia.org/wiki/Favicon#How_to_use
Updated by Alexander Opitz about 10 years ago
- Category set to Frontend
- Status changed from Needs Feedback to New
I don't think that this is a real issue.
Anyway, relative links are possible.
Updated by Gerrit Code Review almost 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36762
Updated by Frederic Gaus almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0927ace4b5851b511ecd28f52fcf6a0b3b482287.
Updated by Gerrit Code Review almost 10 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36856
Updated by Markus Klein almost 10 years ago
- Status changed from Under Review to Resolved
Applied in changeset e558b9ae0dd6464d98bcae572a3aa3d6e921fedd.
Updated by Stephan Bauer almost 10 years ago
Please remove the domain name from the link to make the link relative.
Updated by