Project

General

Profile

Actions

Bug #24481

closed

Missing favicon results in invalid html code

Added by Thomas Koetter about 13 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2011-01-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

On line 498 of class.tslib_pagegen.php the MIME type of the favicon is determined:
$iconMimeType = ' type="' . finfo_file($finfo, PATH_site . $favIcon) . '"';

However, when the given file does not exist the result is "directory". This is not a valid value for the type attribute of the link element. Therefore, the function should at least check for an existing file or for a valid MIME type.

(issue imported from #M16923)


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #43921: felogin not working if favicon.ico link doesn't workClosed2012-12-12

Actions
Actions #1

Updated by Steffen Gebert about 13 years ago

Sounds reasonable, thanks for your report, Thomas!
Can you adjust the code and provide a patch against SVN trunk, please?
https://svn.typo3.org/TYPO3v4/Core/trunk

Actions #2

Updated by Alexander Opitz over 9 years ago

  • Status changed from New to Needs Feedback
  • Target version deleted (0)
  • TYPO3 Version set to 4.3
  • Is Regression set to No

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.2.3)?

Actions #3

Updated by Sascha Egerer over 9 years ago

Is this Problem fixed by #60019 ?

Actions #4

Updated by Sascha Egerer over 9 years ago

Sascha Egerer wrote:

Is this Problem fixed by #60019 ?

It is not.

Actions #5

Updated by Sascha Egerer over 9 years ago

  • Target version set to next-patchlevel
  • TYPO3 Version changed from 4.3 to 6.2
Actions #6

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31282

Actions #7

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31282

Actions #8

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31282

Actions #9

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35157

Actions #10

Updated by Anonymous about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF