Bug #24481
closed
Missing favicon results in invalid html code
100%
Description
On line 498 of class.tslib_pagegen.php the MIME type of the favicon is determined:
$iconMimeType = ' type="' . finfo_file($finfo, PATH_site . $favIcon) . '"';
However, when the given file does not exist the result is "directory". This is not a valid value for the type attribute of the link element. Therefore, the function should at least check for an existing file or for a valid MIME type.
(issue imported from #M16923)
Updated by Steffen Gebert almost 14 years ago
Sounds reasonable, thanks for your report, Thomas!
Can you adjust the code and provide a patch against SVN trunk, please?
https://svn.typo3.org/TYPO3v4/Core/trunk
Updated by Alexander Opitz over 10 years ago
- Status changed from New to Needs Feedback
- Target version deleted (
0) - TYPO3 Version set to 4.3
- Is Regression set to No
Hi,
as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.2.3)?
Updated by Sascha Egerer over 10 years ago
Updated by Sascha Egerer over 10 years ago
- Target version set to next-patchlevel
- TYPO3 Version changed from 4.3 to 6.2
Updated by Gerrit Code Review over 10 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31282
Updated by Gerrit Code Review almost 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31282
Updated by Gerrit Code Review almost 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31282
Updated by Gerrit Code Review almost 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35157
Updated by Anonymous almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9a8e89f4a54a03bf77ace78afd6760ca04544a80.
Updated by