Bug #24619
closed
Pagetree: undelete recursive deleted pages only undeletes the top node, not the other child nodes of the deleted page
0%
Description
not much to say here, the title says it all ...
to reproduce:- enable recursive delete checkbox in user settings
- drag a page with child into delete zone
- push the undelete button
Result: only dragged page is undeleted
Expected result: recover whole subtree
(issue imported from #M17091)
Files
Updated by Philipp Gampe over 13 years ago
da**** ... please move to "backend user interface"
Updated by Stefan Galinski over 13 years ago
It's known and not that easy to solve, because you would to remember the whole branch and recover the nodes step by step with the sorting afterwards. Also this isn't that critical like explained, because IMHO this setting shouldn't be set for normal redacteurs and you can always recover the pages with the recycler.
Updated by Philipp Gampe about 13 years ago
Would it be possible to hide the button then? Or display a warning or something.
It feels just strange the way it is now.
Updated by Susanne Moog about 13 years ago
Displaying a warning is planned, but we did not find the time to do it until now because it had rather low priority. We thought to use an extJS message box (like the alertPopups thing) that warns that you are deleting subpages which can only be recovered by the recycler.
Updated by Philipp Gampe about 13 years ago
After sleeping about it , I prefer not having an undelete button in this case. If this is too much work, I am fine with a waring (however this is done :P).
A flash message like the one you get when not having delete recursive checked would be fine too.
Updated by Stefan Galinski about 13 years ago
I would prefer the extJS message box mentioned by Susanne. If the undelete button shouldn't be displayed in this case, should be discussed in the HCI list.
Updated by Stefan Galinski about 13 years ago
After a short discussion with Steffen, we summarized to change the following:
- don't allow deletion of pages with subpages by drag and drop if you haven't the required rights
- add an improved error handling to fix the original issue mentioned in this ticket
- show a dialog if you want to remove pages with subpages
- don't show the undelete possibility after removing pages with subpages
I hope this makes anybody happy. :-)
Updated by Ernesto Baschny about 13 years ago
Probably related (if not the same issue):
The "undelete" button should also "not be shown" if the deletion was not done because of an error (e.g. you try to delete a page and are not allowed to because it has subpages).
Steps to reproduce:
- set user settings to not allow recursive deletes
- try to delete a page with subpages
- hit the "undelete" button
=> result is the supposetly deleted node being duplicated in the tree
=> desired result: no undelete button (because nothing was deleted)