Bug #24877

rsaauth with more than one login form on one page doesn't work

Added by Marco Huber over 8 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-01-28
Due date:
% Done:

100%

TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you have more than one login form on one page only the last rendered login form will work. This happens because when the second login form is rendered the created private key overwrites the first form's private key. This problem is also described on forge: http://forge.typo3.org/issues/6708

In my patch the class tx_rsaauth_keypair is a singleton so that it will be used only one time. The patch also changes the backend classes to check if the class tx_rsaauth_keypair was already called. And it adds some error handling.

The patch is created against TRUNK revision 10349.

Kind regards,
Marco

(issue imported from #M17388)

rsaauth.patch View (109 KB) Administrator Admin, 2011-01-28 14:19

rsaauth_trunk.patch View (109 KB) Administrator Admin, 2011-01-28 14:41

rsaauth_trunk2.patch View (9.6 KB) Administrator Admin, 2011-01-28 14:43

rsaauth_446.patch View (9.22 KB) Administrator Admin, 2011-02-07 08:21


Related issues

Related to TYPO3 Core - Bug #34568: rsaauth can not be used multiple times on one page Closed 2012-03-06

Associated revisions

Revision 6c4c4d95 (diff)
Added by Tom Ruether almost 6 years ago

[BUGFIX] Only create one keypair in rsaauth

If there are two login forms on one page the second form's private
key overwrites the first form's private key so the first form doesn't
work. With this patch only one keypair gets created and it doesn't
matter how many login forms you have one one page.

Change-Id: I42660140aea72d1888cc73d56e83b823206a0797
Fixes: #24877
Fixes: #6708
Releases: 6.2, 6.1, 6.0, 4.5
Reviewed-on: https://review.typo3.org/10485
Reviewed-by: Stefan Neufeind
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Daniel Gorges
Tested-by: Daniel Gorges
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision 7d3eb359 (diff)
Added by Tom Ruether almost 6 years ago

[BUGFIX] Only create one keypair in rsaauth

If there are two login forms on one page the second form's private
key overwrites the first form's private key so the first form doesn't
work. With this patch only one keypair gets created and it doesn't
matter how many login forms you have one one page.

Change-Id: I42660140aea72d1888cc73d56e83b823206a0797
Fixes: #24877
Fixes: #6708
Releases: 6.2, 6.1, 6.0, 4.5
Reviewed-on: https://review.typo3.org/26709
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision ffc3f2b3 (diff)
Added by Tom Ruether almost 6 years ago

[BUGFIX] Only create one keypair in rsaauth

If there are two login forms on one page the second form's private
key overwrites the first form's private key so the first form doesn't
work. With this patch only one keypair gets created and it doesn't
matter how many login forms you have one one page.

Change-Id: I42660140aea72d1888cc73d56e83b823206a0797
Fixes: #24877
Fixes: #6708
Releases: 6.2, 6.1, 6.0, 4.5
Reviewed-on: https://review.typo3.org/26710
Reviewed-by: Markus Klein
Tested-by: Markus Klein

History

#1 Updated by Marco Huber over 8 years ago

rsaauth_trunk.patch is the right patch... ;-)

#2 Updated by Marco Huber over 8 years ago

where's my brain today? rsaauth_trunk2.patch

#3 Updated by Marco Huber over 8 years ago

Added patch for TYPO3 4.4.6

#4 Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10485

#5 Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10485

#6 Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10485

#7 Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10485

#8 Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10485

#9 Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10485

#10 Updated by Steffi no-lastname-given about 6 years ago

Is there a patch available for TYPO3 4.7.? Have tried it with Version 4.7.14 and sr_feuser_register 3.0.2...doesn't work for me...

#11 Updated by Gerrit Code Review almost 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/10485

#12 Updated by Gerrit Code Review almost 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/10485

#13 Updated by Gerrit Code Review almost 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/10485

#14 Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26709

#15 Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26710

#16 Updated by Tom Ruether almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#17 Updated by Sebahattin Kücük over 5 years ago

I use typo3 4.7.18 and sr_feuser_register 3.1.2 and have the same problem. I am using patch rsaauth_trunk2.patch, but the problem still exists. Please help

#18 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF