Bug #24975
closedhsc called twice for title tag at login page
100%
Description
htmlspecialchars is used twice on the title tag of the login page. If there is a '&' in $TYPO3_CONF_VARS['SYS']['sitename'], this looks very ugly (&).
How it works:
1) index.php calls $TBE_TEMPLATE->startPage('TYPO3 Login: ' . htmlspecialchars($TYPO3_CONF_VARS['SYS']['sitename']), FALSE);
2) in template.php startPage() the pagerenderer is called with $this->pageRenderer->setHtmlTag($htmlTag);
3) in class.t3lib_pagerenderer.php the final htmlspecialchars() is used in line 1494: 'TITLE' => $this->title ? str_replace('|', htmlspecialchars($this->title), $this->titleTag) : '',
So it is safe to remove the hsc() in index.php
(issue imported from #M17503)
Files
Updated by Mr. Hudson about 13 years ago
Patch set 1 of change I711044c1bcce478c6935cf1fb32fef39097ce6a1 has been pushed to the review server.
It is available at http://review.typo3.org/2612
Updated by Georg Ringer about 13 years ago
- Status changed from New to Under Review
- Target version deleted (
0)
Updated by Mr. Hudson about 13 years ago
Patch set 2 of change I711044c1bcce478c6935cf1fb32fef39097ce6a1 has been pushed to the review server.
It is available at http://review.typo3.org/2612
Updated by Georg Ringer about 13 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset dcf8929e0bea07e169915dbaef0e250316dd42da.
Updated by Steffen Gebert about 13 years ago
- Category set to Backend User Interface
- Target version set to 4.5.4
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed