Bug #24975

hsc called twice for title tag at login page

Added by Georg Ringer about 10 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
Start date:
2011-02-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

htmlspecialchars is used twice on the title tag of the login page. If there is a '&' in $TYPO3_CONF_VARS['SYS']['sitename'], this looks very ugly (&).

How it works:
1) index.php calls $TBE_TEMPLATE->startPage('TYPO3 Login: ' . htmlspecialchars($TYPO3_CONF_VARS['SYS']['sitename']), FALSE);

2) in template.php startPage() the pagerenderer is called with $this->pageRenderer->setHtmlTag($htmlTag);

3) in class.t3lib_pagerenderer.php the final htmlspecialchars() is used in line 1494: 'TITLE' => $this->title ? str_replace('|', htmlspecialchars($this->title), $this->titleTag) : '',

So it is safe to remove the hsc() in index.php

(issue imported from #M17503)


Files

hsc-index.patch (531 Bytes) hsc-index.patch Administrator Admin, 2011-02-07 07:54
#1

Updated by Mr. Hudson over 9 years ago

Patch set 1 of change I711044c1bcce478c6935cf1fb32fef39097ce6a1 has been pushed to the review server.
It is available at http://review.typo3.org/2612

#2

Updated by Georg Ringer over 9 years ago

  • Status changed from New to Under Review
  • Target version deleted (0)
#3

Updated by Mr. Hudson over 9 years ago

Patch set 2 of change I711044c1bcce478c6935cf1fb32fef39097ce6a1 has been pushed to the review server.
It is available at http://review.typo3.org/2612

#4

Updated by Georg Ringer over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#5

Updated by Steffen Gebert over 9 years ago

  • Category set to Backend User Interface
  • Target version set to 4.5.4
#6

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF