Project

General

Profile

Actions
Copy link

Bug #25001

closed

Usage of deprecated PHP < 5.3 function calls

Added by Michiel Roos over 13 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-02-11
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

// checking for 'dl()'
typo3/sysext/adodb/adodb/adodb-pear.inc.php:365: @dl($name . $dlext);
typo3/sysext/em/classes/parser/class.tx_em_parser_xmlabstractparser.php:77: if (!((bool) ini_get('enable_dl') && !(bool) ini_get('safe_mode') && function_exists('dl') && dl($prefix . $this->requiredPHPExt . PHP_SHLIB_SUFFIX))) {
typo3/sysext/openid/lib/php-openid/Auth/OpenID/BigMath.php:380: if (@dl($module . "." . PHP_SHLIB_SUFFIX)) {
typo3/sysext/openid/lib/php-openid/Auth/Yadis/XML.php:352: if (@dl($libname)) {

// checking for 'set_magic_quotes_runtime()'
typo3/contrib/swiftmailer/classes/Swift/ByteStream/FileByteStream.php:82: set_magic_quotes_runtime(0);
typo3/contrib/swiftmailer/classes/Swift/ByteStream/FileByteStream.php:87: set_magic_quotes_runtime(1);
typo3/contrib/swiftmailer/classes/Swift/KeyCache/DiskKeyCache.php:174: set_magic_quotes_runtime(0);
typo3/contrib/swiftmailer/classes/Swift/KeyCache/DiskKeyCache.php:183: set_magic_quotes_runtime(1);
typo3/contrib/swiftmailer/classes/Swift/KeyCache/DiskKeyCache.php:202: set_magic_quotes_runtime(0);
typo3/contrib/swiftmailer/classes/Swift/KeyCache/DiskKeyCache.php:210: set_magic_quotes_runtime(1);

The test script also gives false positives. It finds 'split()' in pieces of JS inside PHP files for example.
(issue imported from #M17542)

Files

Download all files
phpDeprecatedCheck (997 Bytes) phpDeprecatedCheck Administrator Admin, 2011-02-11 08:12
phpDeprecatedCheck-0.0.2 (1.42 KB) phpDeprecatedCheck-0.0.2 Administrator Admin, 2011-02-11 08:35

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #25395: Remove explicit checks for PHP < 5.3Closed2011-03-25

Actions
Actions
Copy link
 #1

Updated by Michiel Roos over 13 years ago

Also the following deprecateded ini directives are used:

// checking for 'magic_quotes_runtime()'
typo3/sysext/adodb/adodb/adodb-xmlschema.inc.php:1307:          ini_set("magic_quotes_runtime", 0);
typo3/sysext/adodb/adodb/adodb-xmlschema.inc.php:2197:          ini_set("magic_quotes_runtime", $this->mgq );
typo3/sysext/adodb/adodb/adodb-xmlschema03.inc.php:1412:                ini_set("magic_quotes_runtime", 0);
typo3/sysext/adodb/adodb/adodb-xmlschema03.inc.php:2378:                ini_set("magic_quotes_runtime", $this->mgq );
Actions
Copy link
 #2

Updated by Steffen Gebert over 12 years ago

  • Status changed from New to Rejected
  • Target version deleted (0)

that's all part of 3rd-party libraries. not our business..

Actions
Copy link
 #3

Updated by Ingo Renner over 12 years ago

  • Status changed from Rejected to Accepted

It very well is our business since we use those libraries. The solution for this issue would be to update to newer versions of the libraries or to at least file issues in their bug tracking systems.

Actions
Copy link
 #4

Updated by Markus Klein almost 11 years ago

  • Status changed from Accepted to Needs Feedback

Is this still an issue today? Swiftmailer was updated.

Actions
Copy link
 #5

Updated by Michiel Roos almost 11 years ago

// checking for 'set_magic_quotes_runtime()'
classes/Swift/ByteStream/FileByteStream.php:82: set_magic_quotes_runtime(0);
classes/Swift/ByteStream/FileByteStream.php:87: set_magic_quotes_runtime(1);
classes/Swift/KeyCache/DiskKeyCache.php:174: set_magic_quotes_runtime(0);
classes/Swift/KeyCache/DiskKeyCache.php:183: set_magic_quotes_runtime(1);
classes/Swift/KeyCache/DiskKeyCache.php:202: set_magic_quotes_runtime(0);
classes/Swift/KeyCache/DiskKeyCache.php:210: set_magic_quotes_runtime(1);

These are harmless calls since they will only be called if $this->_quotes is true.

$this->_quotes is set by http://nl1.php.net/get_magic_quotes_runtime which will always return false in the current PHP version.

Please close this issue.

Actions
Copy link
 #6

Updated by Alexander Opitz almost 11 years ago

  • Status changed from Needs Feedback to Closed
Actions
Copy link

Also available in: Atom PDF