Bug #25280: metaCharsetTag is not truly HTML5 nor XHTML (in general) compatible - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #25280

closed

metaCharsetTag is not truly HTML5 nor XHTML (in general) compatible

Added by Sigfried Arnold over 13 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Frontend

Target version:

Start date:

2011-03-08

Due date:

% Done:

Estimated time:

TYPO3 Version:

4.5

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

$metaCharsetTag gets set hardcoded to <meta http-equiv="Content-Type" content="text/html; charset=|" />'; in class.t3lib_pagerenderer.php

If you want to use XHTML5, XHTML 1.0 or XHTML 1.1 the proper you need modify it.

This option should be set automatically by setting config.doctype

for HTML5 or XHTML5 it should be
<meta charset="|"> or <meta charset="|" />

for other xhtml dialects it should be
<meta http-equiv="Content-Type" content="application/xhtml+xml; charset=|" />
or
<meta http-equiv="Content-Type" content="application/xml; charset=|" />
(issue imported from #M17893)

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Chris topher over 13 years ago

Hi Sigfried,

thanks for your report!

Have a look at Mantis 0016577 = #24212, where people already provided a patch for this problem.

Can you push that to Gerrit so that it can be reviewed?

Actions

Copy link

Updated by Sigfried Arnold over 13 years ago

What do you mean by "push that to Gerrit"? ;)

The patch in 0016577 seems to be faulty since it adds the meta element with XHTML serialization while selecting html_5 - in addition there is no way to select the content type - only the charset can be configured - but it is a step in the right direction.

i guess it will be a long time till TYPO3 can truly send application/xhtml+xml for modern Browsers.

Actions

Copy link

Updated by Chris topher over 13 years ago

Improve the patch from 24212 to fix what you mean! :-)

Don't people call sending in patches "pushing" today? ;-) And I mean that Gerrit! Not the one from next door, but the new reviewing system at http://review.typo3.org

Actions

Copy link

Updated by Sigfried Arnold over 13 years ago

WTF - i'm confused. There is the core mailing list with its SVN patch requests rules, the bugtracker (Mantis), the Wiki with the Bug-Day stuff and now a review-System? its very confusing to keep track of the process :(

Actions

Copy link

Updated by Chris topher over 13 years ago

Basically everything stays the same: The wiki, the bug tracker and the bug-days don't change.
Gerrit only replaces the Core mailing list with its SVN patch requests. But the basic procedure of contributing a patch is still the same: You request a review (with Gerrit now) and people review the patch. Also the voting rules continue to apply, but voting can be done easily in Gerrit.

I also have not yet tried how that works with getting a patch into Gerrit. But there already is a documentation at http://wiki.typo3.org/Git_Gerrit

Actions

Copy link

Updated by Chris topher over 13 years ago

Target version deleted (0)
TYPO3 Version set to 4.5

Sigfried Arnold wrote:

$metaCharsetTag gets set hardcoded to
<meta http-equiv="Content-Type" content="text/html; charset=|" />';
in class.t3lib_pagerenderer.php
This option should be set automatically by setting config.doctype
for HTML5 or XHTML5 it should be
<meta charset="|"> or <meta charset="|" />

That is possible now after #24212 has been committed.

for other xhtml dialects it should be
<meta http-equiv="Content-Type" content="application/xhtml+xml; charset=|" />
or
<meta http-equiv="Content-Type" content="application/xml; charset=|" />

I guess that is still not possible?

Actions

Copy link