Project

General

Profile

Actions

Bug #24212

closed

Update meta tag "charset" for HTML5 – document character-encoding declaration

Added by Morton Jonuschat over 13 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Frontend
Target version:
Start date:
2010-11-26
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When setting the doctype to html_5 TYPO3 still generates a http-equiv meta tag for setting the character encoding.

The attached patch makes the meta charset tag used by the pageRenderer configurable with a setter and adjusts tslib_pagegen so that it uses the recommended <meta charset=...> Tag.

(issue imported from #M16577)


Files

html5-charset.diff (1.19 KB) html5-charset.diff Administrator Admin, 2010-11-26 17:16
html5_metacharset.diff (1.09 KB) html5_metacharset.diff Administrator Admin, 2010-12-17 15:07

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Feature #20736: HTML5 doctype implementationClosedSteffen Kamper2009-07-08

Actions
Related to TYPO3 Core - Bug #25280: metaCharsetTag is not truly HTML5 nor XHTML (in general) compatibleClosed2011-03-08

Actions
Actions #1

Updated by Mam Violeng over 13 years ago

The old patch is not working and we move the function which called the setMetaCharsetTag to the existing switch condition html5 and created a new patch file.

Actions #2

Updated by Chris topher over 13 years ago

Hi Violeng,

thanks for your contribution!

Do you know, that you must send your patch to Core List to get it in the next releases of TYPO3?
Check out http://typo3.org/teams/core/core-mailinglist-rules/
There you already find an example of what your mail should look like.

Actions #3

Updated by Mam Violeng over 13 years ago

Hi Christoper,

Yes, I already sent the patch to the Core List.

Actions #4

Updated by Chris topher over 13 years ago

Ahh, thanks for the note. Seems like I have missed that thread...

Actions #5

Updated by Riccardo De Contardi over 13 years ago

A little question: what if I'd want to use a custom doctype?
I'm asking because I'd like to use the "boilerplate standard", so my doctype is:

config.doctype(
<!doctype html>





)

Actions #6

Updated by Morton Jonuschat over 13 years ago

In TYPO3 4.5 you could use the render-postProcess Hook to modify the doctype to get this kind of doctype. See #24214 for some more information on this.

Actions #7

Updated by Steffen Gebert about 13 years ago

  • Category deleted (Communication)
  • Assignee set to Steffen Gebert
  • Target version deleted (0)
Actions #8

Updated by Mr. Hudson almost 13 years ago

Patch set 1 of change I8275b677e5394f59dbd1efc65ced93f57149ebae has been pushed to the review server.
It is available at http://review.typo3.org/2280

Actions #9

Updated by Chris topher almost 13 years ago

  • Category set to Frontend
  • Status changed from New to Under Review
Actions #10

Updated by Mr. Hudson almost 13 years ago

Patch set 2 of change I8275b677e5394f59dbd1efc65ced93f57149ebae has been pushed to the review server.
It is available at http://review.typo3.org/2280

Actions #11

Updated by Mr. Hudson almost 13 years ago

Patch set 1 of change Ic1ec479086d955bed407e2c87fdc6ca0d9bc32f6 has been pushed to the review server.
It is available at http://review.typo3.org/2318

Actions #12

Updated by Susanne Moog almost 13 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Chris topher almost 13 years ago

  • Target version set to 4.5.4
Actions #14

Updated by Susanne Moog almost 13 years ago

  • Category changed from Frontend to 1050
Actions #15

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions #16

Updated by Oliver Hader over 6 years ago

  • Category changed from 1050 to Frontend
Actions

Also available in: Atom PDF