TYPO3 Core

Can confirm this Bug.

TYPO3 4.5.2
- DAM
- Templavoila
- realurl

Attached Patch fixed this Problem

Sounds reasonable!

Klaus, are you able to push this change to the review system Gerrit?
See http://wiki.typo3.org/Contribution_Walkthrough for explanations.

If you want to do so (which is appreciated :)) and have trouble: Tomorrow's TYPO3 Bug Day is the "Git Edition". If you need help, just join IRC and you get support during your first steps.

P.S: Please leave the added comment out.

Hi Klaus,

I just reproduced this issue. However, your fix doesn't work for me. Do you use absRefPrefix?

For me, this piece of code (which directly follows the code you've modified) causes trouble:

// If go for an absolute link, add site_path if it's not taken care about by absRefPrefix
if (!$GLOBALS['TSFE']->config['config']['absRefPrefix'] && $targetDomain !== '') {
  $targetDomain = $currentDomain . rtrim(t3lib_div::getIndpEnv('TYPO3_SITE_PATH'), '/');
}

As $targetDomain is the other domain and I don't have absRefPrefix set, $targetDomain is replaced with $currentDomain, which causes the described error.

Ah, I just noticed that there has been a recent change, which causes the problems I realized.
Your patch itself is right and helps, but the piece of code cited above also has to be fixed.

Maybe by additionally checking for

 && $absoluteUrlScheme === parse_url(t3lib_div::getIndpEnv('TYPO3_REQUEST_URL'), PHP_URL_SCHEME)

Hi Steffen,

sorry for the late and short response, I was occupied with other things.

Yes, I use absRefPrefix, so I wouldn't have noticed the problem. And my patch took the 4.5.2 release version as basis.

As the SITE_PATH logic can't work with cross-domain links anyway (there is potentially a different TYPO3_SITE_PATH for each domain), I assume it's safe to add the check for

&& strpos($currentDomain,$targetDomain)!==false

or even more direct:
&& ($currentDomain==$targetDomain)

instead, which looks more elegant to me and answers the question we want to check directly: Do we have a cross domain link here? This missing check seems like a bug for me anyway.

I went halfway through the gerrit/contribution process, and I'm not sure wether I find the time to push the proposed changes to gerrit in the next days. The toolchain seems very sophisticated, but a bit complicated for the git-illiterate among us (like me). The possibility of uploading the diff-files directly to the review system via web interface would probably be a big step forward for those who work with non-distributed version control systems like subversion.