Bug #25470
closed
$GLOBALS['TYPO3_CONF_VARS']['BE']['unzip_path'] setting used with and without unzip command
Added by Patrick Rodacker over 13 years ago.
Updated about 6 years ago.
Description
The configuration option
$GLOBALS['TYPO3_CONF_VARS']['BE']['unzip_path']
is used in two different functions within the core:
The start() function in the class t3lib_extFileFunctions sets the var $this->unzipPath
$this->unzipPath = $GLOBALS['TYPO3_CONF_VARS']['BE']['unzip_path'];
which is used in the function
func_unzip() expecting the configuration to be the path only without the command including a trailing slash:
$cmd = $this->unzipPath . 'unzip -qq "' . $theFile . '" -d "' . $theDest . '"';
The other occurence of the configuration setting is within the extension em. The static function unzip in the class tx_em_Tools expects the setting to include the unzip command:
$cmd = $GLOBALS['TYPO3_CONF_VARS']['BE']['unzip_path'] . ' -o ' . escapeshellarg($file);
Consider that this fix should be backwards-compatible. If someone used to set the program name in unzip_path, then his setup should remain running!
Maybe the solution should be implementend like the path for the setting:
$GLOBALS['TYPO3_CONF_VARS']['BE']['diff_path']
which includes the command itself?
Patch set 1 of change I67ef7b3544c2c2085f959229ff4343cbb736fde6 has been pushed to the review server.
It is available at http://review.typo3.org/1370
Patch set 2 of change I67ef7b3544c2c2085f959229ff4343cbb736fde6 has been pushed to the review server.
It is available at http://review.typo3.org/1370
Patch set 1 of change Iae834f7577450ab7173c9827db508bd464ba1fa3 has been pushed to the review server.
It is available at http://review.typo3.org/1374
Patch set 3 of change I67ef7b3544c2c2085f959229ff4343cbb736fde6 has been pushed to the review server.
It is available at http://review.typo3.org/1370
Patch set 1 of change Ia34f8ae2ac89ed7c62fbb3165b4fda5388179273 has been pushed to the review server.
It is available at http://review.typo3.org/1383
Patch set 2 of change Iae834f7577450ab7173c9827db508bd464ba1fa3 has been pushed to the review server.
It is available at http://review.typo3.org/1374
- Status changed from New to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Under Review
- Is Regression set to No
- Is Regression changed from No to Yes
- Is Regression changed from Yes to No
- Status changed from Under Review to Resolved
- Status changed from Resolved to Closed
Also available in: Atom
PDF