Project

General

Profile

Actions

Bug #25481

closed

default setting for styles.content.links.target fails in CSC's static template constants

Added by Anonymous about 13 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2011-03-31
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

in the constants of CSC's static template there's a declaration of PAGE_TARGET at the very bottom of the file, but above that we're trying to read its value in order to set the constant styles.content.links.target.

typo3/sysext/css_styled_content/static/constants.txt:24

styles.content.links {
  ...
  extTarget = _blank
  target = {$PAGE_TARGET}
  ...
}

typo3/sysext/css_styled_content/static/constants.txt:134

PAGE_TARGET = 

apparently it is possible to assign constants to other constants, i didn't know that until now. but of course the constant has to be declared before we try to read its value. you can easily see this problem by looking into the backend object browser searching in the setup-view for PAGE_TARGET. Please have a look at the attached screenshot.

placing the second piece of code above the first one, seems to fix this issue.


Files

Actions #1

Updated by Alexander Opitz almost 10 years ago

  • Status changed from New to Needs Feedback
  • Is Regression set to No

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.2.3)?

Actions #2

Updated by Anonymous almost 10 years ago

Yes, still an issue in 6.2.x, but I have no idea why the heck I reported this 3 years ago ;-)

Maybe it's not a problem, doesn't break anything in the frontend and just looks ugly in the TS object browser?

Actions #3

Updated by Alexander Opitz almost 10 years ago

  • Status changed from Needs Feedback to New
Actions #4

Updated by Riccardo De Contardi almost 9 years ago

the problem seems still present in 6.2.12; the typoscript object browser reads:

lib.parseFunc.tags.link.typolink.target.override = {$PAGE_TARGET}

lib.parseFunc_RTE.tags.link.typolink.target.override = {$PAGE_TARGET}

lib.parseFunc_RTE.externalBlocks.li.stdWrap.parseFunc.tags.link.typolink.target.override = {$PAGE_TARGET}

tt_content.image.20.1.imageLinkWrap.typolink.target.override = {$PAGE_TARGET}

tt_content.mailform.20.target.override ={$PAGE_TARGET}

tt_content.search.20.renderObj.10.typolink.target.override = {$PAGE_TARGET}

tt_content.search.20.target.override ={$PAGE_TARGET}

tt_content.search.30.target.override ={$PAGE_TARGET}

Is there a reason why PAGE_TARGET = is at the bottom of constants.txt?

Actions #5

Updated by Daniel Goerz over 8 years ago

  • Category changed from Content Rendering to 1599
  • TYPO3 Version changed from 4.5 to 7

The problem is solely the display of the ObjectBrowser since the value is correctly set.

Test:
  1. Edit the constant in the file in sysext/css_styled_content/Static/constants.txt
  2. Add a link to a internal page in a Text CE (with RTE)
  3. Clear caches
  4. Inspect the a-tag in the frontend

TLDR:
The ObjectBrowser does not display a constant substituted by another constant.

Actions #6

Updated by Daniel Goerz over 8 years ago

  • Category changed from 1599 to Backend User Interface
Actions #7

Updated by Riccardo De Contardi about 7 years ago

This issue still affects 8.6-dev (latest master)

Actions #8

Updated by Riccardo De Contardi about 6 years ago

I think I can close it; it seems already solved for version 8.7.11

This is the test I performed:

1) I install Css Styled Content and uninstall Fluid Styled Content

2) Check EXT:css_styled_content/Configuration/TypoScript/Constants.txt

line 14:

styles.content.links {
   extTarget = _blank
     target = {$PAGE_TARGET}

line 114

PAGE_TARGET =

3) Check EXT:css_styled_content/Configuration/TypoScript/ContentElementPartials/Menu.txt

line 9:

lib.defaultMenu {
     1 {
         target.override = {$PAGE_TARGET}

4) Please note that those values are reported on TS Template Analyzer

5) Template > TypoScript Object Browser > look for lib.defaultMenu and here is what it can be seen:

If you think that this is the wrong decision or that a different test should be performed, please reopen this issue or open a new issue with a reference to this one. Thank you.

Actions #9

Updated by Riccardo De Contardi about 6 years ago

  • Status changed from New to Closed
Actions #10

Updated by Riccardo De Contardi about 6 years ago

Seem also solved for 7.6.25; only 6.2.x seems still affected.

Actions

Also available in: Atom PDF