Project

General

Profile

Actions

Bug #25777

closed

Cannot use single quote in TS constant part

Added by Xavier Perseguers over 13 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2011-04-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

It is not possible to save a TS template if the constants contain a single quote, when using MSSQL.

After analyzing the problem, I located it in class.ux_t3lib_db.php in methods INSERTquery and UPDATEquery and only for 'XL' fields (clob) not 'B' (blob).

Methods should be updated as this:

before:

} elseif (!$this->runningNative() && $this->sql_field_metatype($table, $k) == 'XL') {
    // we skip the field in the regular UPDATE statement, it is only in clobfields
    $clobfields[$this->quoteFieldNames($k)] = $v;
} else {

after:

} elseif (!$this->runningNative() && $this->sql_field_metatype($table, $k) == 'XL') {
    // we skip the field in the regular UPDATE statement, it is only in clobfields
    $clobfields[$this->quoteFieldNames($k)] = $this->quoteStr($v, $table);
} else {

This does not seem to affect Oracle though.

Actions #1

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change I02c9b84d624fe5ac6cba0039826312ab62b844e1 has been pushed to the review server.
It is available at http://review.typo3.org/1482

Actions #2

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change Id8a96bfe8fb6bfc5e7589bea5b2d378dbb5ab8bf has been pushed to the review server.
It is available at http://review.typo3.org/1483

Actions #3

Updated by Xavier Perseguers over 13 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Michael Stucki almost 11 years ago

  • Project changed from 329 to TYPO3 Core
  • Category deleted (MS SQL Server)
  • Target version deleted (1.2.3 (TYPO3 4.5.x))
Actions #5

Updated by Michael Stucki almost 11 years ago

  • Category set to 999
Actions #6

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF