Project

General

Profile

Actions
Copy link

Bug #26734

closed

Android not detected properly by t3lib_utility_Client::getBrowserInfo()

Added by Francois Suter over 13 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Francois Suter
Category:
Miscellaneous
Target version:
4.5.4
Start date:
2011-05-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Android system is not properly detected by t3lib_utility_Client::getBrowserInfo() depending on what browser is used on the mobile device. For example using Opera Mini, the following User-Agent info is received:

Opera/9.80 (Android; Opera Mini/6.0.24556/24.816; U; en) Presto/2.5.25
Version/10.54

but in order to detect an Android device, t3lib_utility_Client::getBrowserInfo() expects to find "Linux" in the User-Agent string. Indeed the Android detection is a sub-test of the Linux detection.

I propose to move the Android test at the same level of the Linux test.

Actions
Copy link
 #1

Updated by Francois Suter over 13 years ago

How to test:

- put the following TS into your page (assuming your PAGE object is called "page"):

[system = android]
page.1 = TEXT
page.1.value = Android
[else]
page.1 = TEXT
page.1.value = Not Android
[global]

then access your site with an Android device using Opera Mini. Before the patch, Android does not get detected. After the patch, it does.

Actions
Copy link
 #2

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change I5033dd6c2669f3fbde6dfe82fdb071d9e802d926 has been pushed to the review server.
It is available at http://review.typo3.org/1998

Actions
Copy link
 #3

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change I5e724802f1d8e5bf3b8a824a4fef7755eca779db has been pushed to the review server.
It is available at http://review.typo3.org/1999

Actions
Copy link
 #4

Updated by Francois Suter over 13 years ago

How to test #2: run the improved unit tests for t3lib_utility_Client included in second version of patch ;-)

Actions
Copy link
 #5

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change I0d870a0b8e7a00bce0dbbf964338f1e83ca821cc has been pushed to the review server.
It is available at http://review.typo3.org/2000

Actions
Copy link
 #6

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change I0d870a0b8e7a00bce0dbbf964338f1e83ca821cc has been pushed to the review server.
It is available at http://review.typo3.org/2000

Actions
Copy link
 #7

Updated by Oliver Hader over 13 years ago

  • Target version changed from 4.5.3 to 4.5.4
Actions
Copy link
 #8

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change I5e724802f1d8e5bf3b8a824a4fef7755eca779db has been pushed to the review server.
It is available at http://review.typo3.org/1999

Actions
Copy link
 #9

Updated by Francois Suter over 13 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #10

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF