Project

General

Profile

Actions
Copy link

Bug #27230

closed

Bug #25335: Make TYPO3 free of NOTICE errors

cmpIPv4: prevent E_NOTICE, cleanup compare, testcases

Added by Stefan Neufeind over 13 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Stefan Neufeind
Category:
-
Target version:
4.6.0-beta2
Start date:
2011-06-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.4
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Cleanup E_NOTICE when no bitmask is supplied.

And while we're at it, cleanup the unreadable strcmp() at the end as well as provide testcases.

Actions
Copy link
 #1

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change I3836d3c53ab6093e3427047c4a5089778dd04ca2 has been pushed to the review server.
It is available at http://review.typo3.org/2536

Actions
Copy link
 #2

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change I3836d3c53ab6093e3427047c4a5089778dd04ca2 has been pushed to the review server.
It is available at http://review.typo3.org/2536

Actions
Copy link
 #3

Updated by Chris topher over 13 years ago

  • Parent task set to #25335
Actions
Copy link
 #4

Updated by Mr. Hudson over 13 years ago

Patch set 3 of change I3836d3c53ab6093e3427047c4a5089778dd04ca2 has been pushed to the review server.
It is available at http://review.typo3.org/2536

Actions
Copy link
 #5

Updated by Mr. Hudson over 13 years ago

Patch set 4 of change I3836d3c53ab6093e3427047c4a5089778dd04ca2 has been pushed to the review server.
It is available at http://review.typo3.org/2536

Actions
Copy link
 #6

Updated by Thorsten Kahler over 13 years ago

  • Status changed from New to Under Review
  • Target version set to 4.6.0-beta2
  • TYPO3 Version changed from 4.6 to 4.4

TYPO3 4.4 already contains the same code in t3lib_div::cmpIPv4() so IMHO this might be fixed in earlier versions as well.

Actions
Copy link
 #7

Updated by Mr. Hudson over 13 years ago

Patch set 5 of change I3836d3c53ab6093e3427047c4a5089778dd04ca2 has been pushed to the review server.
It is available at http://review.typo3.org/2536

Actions
Copy link
 #8

Updated by Stefan Neufeind over 13 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Xavier Perseguers over 12 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF