Bug #27258
closed
list sort direction indicator is inconsistent
0%
Description
Sorting arrows in various lists are inconsitent or missing
- list module: direction is wrong, color is inconsistent and differs from new extJS grids.
- completely missing file list module
- Add new sprite, copied from typo3/sysext/t3skin/icons/gfx/arrow(up|down).png
- use sprite in list module and switch direction
- add in file list module
Comments
The patch created new sprites status-status-sort-asc' and 'status-status-sort-desc' because its more a status than an action.
The icons could be impromed because it still differes from grid version (white on dark gray) and has no contrast in file list module (t3-row-header) but cannot be white because its in the .c-headLine row in db list module. But its still better than nothing and should not be the old red arrow in my eyes.
The patch also fixes a typo and corrects one line in phpdoc
See also unanswered question in #11127
Files
Updated by Markus Klein almost 13 years ago
Hi!
Can you please push a change request to review.typo3.org?
What typo do you mean and what phpdoc change does you patch include?
Sorry for not reading your patch, but it's extremely large and unclear.
What branches are affected?
Updated by Joh. Feustel almost 13 years ago
- File 27258_no-css.patch 27258_no-css.patch added
I will push it to gerrit today.
Patch was prepared for 4.6. I am not sure if this direction switch can be treated as a bugfix for 4.5 but I can push it to 4.5 also and let the release managers decide.
I just uploaded a patch file without the full css change. Should be clear now.
Updated by Mr. Hudson almost 13 years ago
Patch set 1 of change If6f8fcfbed8fe0d246257bcdbe2cf535750b42bb has been pushed to the review server.
It is available at http://review.typo3.org/2539
Updated by Mr. Hudson almost 13 years ago
Patch set 2 of change If6f8fcfbed8fe0d246257bcdbe2cf535750b42bb has been pushed to the review server.
It is available at http://review.typo3.org/2539
Updated by Joh. Feustel almost 12 years ago
Seems that this has been resolved in #11127 now
Updated by Marcus Schwemer almost 12 years ago
@ Joh.
Can you abandon your change on review.typo3.org and close this issue here?
Thanks
Marcus
Updated by Joh. Feustel almost 12 years ago
change abandoned.
Seems that I am not able to change the status to closed.
Updated by