TYPO3 Core

Hello Xavier,

here the code as sent to you today:

    /**
     * Get value in quotes from $parseString.
     * NOTICE: If a query being parsed was prepared for another database than MySQL this function should probably be changed
     *
     * @param    string        String from which to find value in quotes. Notice that $parseString is passed by reference and is shortend by the output of this function.
     * @param    string        The quote used; input either " or '
     * @return    string        The value, passed through stripslashes() !
     */
    protected function getValueInQuotes(&$parseString, $quote) {

        /*** Thanks to Nils Blattner for the regexp and the support while doing this. */
        if(preg_match('/' . $quote . $quote . '[^[:space:]]/', $parseString)) {
            $parseString = preg_replace('/' . $quote . '(([^' . $quote . ']*|' . $quote . $quote . ')*)' . $quote . '/', '$1', $parseString);
        }

        $parts = explode($quote, substr($parseString, 1));

        $buffer = '';
        foreach ($parts as $k => $v) {
            $buffer .= $v;

            $reg = array();
            preg_match('/\\\\$/', $v, $reg);
            if ($reg AND strlen($reg[0]) % 2) {
                $buffer .= $quote;
            } else {
                $parseString = ltrim(substr($parseString, strlen($buffer) + 2));
                return $this->parseStripslashes($buffer);
            }
        }
    }

This code can be added at the end of the ux_t3lib_sqlparser class so it will override the original method.

Greets

Tizian

Patch set 1 of change I857aebb00efd1dc0752d42d436e6e9950a336370 has been pushed to the review server.
It is available at http://review.typo3.org/4192

Hi there,

we finally managed to get this work!

Here the code:

    /**
     * Get value in quotes from $parseString.
     * NOTICE: If a query being parsed was prepared for another database than MySQL this function should probably be changed
     *
     * @param    string        String from which to find value in quotes. Notice that $parseString is passed by reference and is shortend by the output of this function.
     * @param    string        The quote used; input either " or '
     * @return    string        The value, passed through stripslashes() !
     */
    protected function getValueInQuotes(&$parseString, $quote) {

        /*** Thanks to Nils Blattner for the regexp and the support while doing this. */        
        $previousIsQuote = false;
        $inQuote = false;

        // Go through the whole string
        for ($c = 0; $c < strlen($parseString); $c++) {
            // If the parsed string character is the quote string
            if ($parseString{$c} === $quote) {
                // If we are already in a quote
                if ($inQuote) {
                    // Was the previous a quote?
                    if ($previousIsQuote) {
                        // If yes, replace it by a \
                        $parseString{$c - 1} = '\\';
                    }
                    // Invert the value
                    $previousIsQuote = !$previousIsQuote;
                } else {
                    // so we are in a quote since now
                    $inQuote = true;
                }
                // So the parsed character is not a quote char and the previous char was a quote? so we are not in a quote anymore
            } elseif ($inQuote && $previousIsQuote) {
                $inQuote = false;
                $previousIsQuote = false;
                // So we are still in a quote and the previous is not a quote
            } else {
                $previousIsQuote = false;
            }
        }

        $parts = explode($quote, substr($parseString, 1));

        $buffer = '';
        foreach ($parts as $k => $v) {
            $buffer .= $v;

            $reg = array();
            preg_match('/\\\\$/', $v, $reg);
            if ($reg AND strlen($reg[0]) % 2) {
                $buffer .= $quote;
            } else {
                $parseString = ltrim(substr($parseString, strlen($buffer) + 2));
                return $this->parseStripslashes($buffer);
            }
        }
    }

IDEA: This might be refactored in a style that there could be a preExplodeParseStringHook (or something like this) that could be defined in the handler, so this would not be executed when using a MySQL handler for example (or everything else which quotes single quotes with backslashes).

Greets Tizian

Patch set 2 of change I857aebb00efd1dc0752d42d436e6e9950a336370 has been pushed to the review server.
It is available at http://review.typo3.org/4192

Patch set 3 of change I857aebb00efd1dc0752d42d436e6e9950a336370 has been pushed to the review server.
It is available at http://review.typo3.org/4192

Patch set 4 of change I857aebb00efd1dc0752d42d436e6e9950a336370 has been pushed to the review server.
It is available at http://review.typo3.org/4192

Patch set 5 of change I857aebb00efd1dc0752d42d436e6e9950a336370 has been pushed to the review server.
It is available at http://review.typo3.org/4192

Patch set 6 of change I857aebb00efd1dc0752d42d436e6e9950a336370 has been pushed to the review server.
It is available at http://review.typo3.org/4192

Patch set 1 of change I929d5375480bd872b54fd458f67474ed21f29a3c has been pushed to the review server.
It is available at http://review.typo3.org/5713