Bug #28085
closedt3lib_div::debugRows can't return data anymore
100%
Description
In TYPO3 4.5 t3lib_div::debugRows() was deprecated and moved to t3lib_utility_Debug::debugRows()
/** * Displays an array as rows in a table. Useful to debug output like an array of database records. * * @param mixed Array of arrays with similar keys * @param string Table header * @param boolean If TRUE, will return content instead of echo'ing out. * @return void Outputs to browser. * @deprecated since TYPO3 4.5 - Use t3lib_utility_Debug::debugRows instead */ public static function debugRows($rows, $header = '', $returnHTML = FALSE) { self::logDeprecatedFunction(); t3lib_utility_Debug::debugRows($rows, $header, $returnHTML); }
The problem is, that t3lib_utility_Debug::debugRows() is just called but not returned, despite the fact that debugRows() offers an option $returnHTML to return an HTML table.
So in the (a bit unlikely) case someone relies on values returned by t3lib_div::debugRows(), 4.5 broke his code.
Adding a simple "return" will solve this problem.
Updated by Xavier Perseguers over 13 years ago
- Status changed from New to Accepted
Although I hate those methods with an invalid phpDoc ("@return void")
Updated by Mr. Hudson over 13 years ago
Patch set 1 of change I4e328db1b78975a7baed386a316dc50f00a0ac40 has been pushed to the review server.
It is available at http://review.typo3.org/3238
Updated by Sebastian Michaelsen over 13 years ago
Xavier Perseguers wrote:
Although I hate those methods with an invalid phpDoc ("@return void")
I have something in preparation for you ;)
Updated by Sebastian Michaelsen over 13 years ago
- Status changed from Accepted to Resolved
- % Done changed from 0 to 100
Applied in changeset acfa3ca029f429ac64bfce94c6f535e4c7690fb5.