Project

General

Profile

Actions

Bug #28882

closed

Workspace module - diff-view should only show fields configured in TCA 'showRecordFieldList'

Added by Simon Apold over 13 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2011-08-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hi,

i found a bug in the detailed diff-view of the workspace module.
If a tt_news record (or another extension-record) is listed as a new version in the workspace module, the diff-view shows all modified DB fields (uid, pid, crdate, l18n_diffsource, etc.). The correct behaviour would be that it just shows the modified fields configured in $TCA[tablename][interface][showRecordFieldList].

There is such a query in the sources but it expects that the whole TCA Array for every table is loaded. You have to load the TCA for each table with t3lib_div::loadTCA(tablename).

I attached a patch file to fix this bug.

Regards,
Simon


Files

patch.diff (563 Bytes) patch.diff Simon Apold, 2011-08-10 08:45
Actions #1

Updated by Tolleiv Nietsch over 13 years ago

  • Status changed from New to Needs Feedback

Pretty obvious. Would you mind submitting it to Gerrit?

Actions #2

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change Ia6bf921726d7dd6da85a666365ce48c0ac6c16ae has been pushed to the review server.
It is available at http://review.typo3.org/4463

Actions #3

Updated by Tolleiv Nietsch over 13 years ago

  • Status changed from Needs Feedback to Under Review
Actions #4

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change I56b098accc2dd31db69d7690cd5d29f53f74e093 has been pushed to the review server.
It is available at http://review.typo3.org/4464

Actions #5

Updated by Simon Apold over 13 years ago

Thanks for submitting the change. Last week I was on vacation so I wasn't able to.

Actions #6

Updated by Simon Apold over 13 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:0bf9fb36e3ba20a600b6aed799a9a3c53fd191fd.

Actions #7

Updated by Michael Stucki almost 11 years ago

  • Category changed from Bugs to Workspaces
Actions #8

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions #9

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF