Project

General

Profile

Actions

Task #29339

closed

Merge linkvalidator for beta2

Added by Philipp Gampe over 12 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2011-08-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #30589: Revert change in interface signatureClosed2011-10-05

Actions
Actions #1

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change I9efee664ffeb5174f8d5c382411d1b1abc6a26a4 has been pushed to the review server.
It is available at http://review.typo3.org/4673

Actions #2

Updated by Xavier Perseguers over 12 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Change has been successfully cherry-picked as 0d4f5ab8d5ad2e9f9026457afd110e45fd206293.

Actions #3

Updated by Lorenz Ulrich over 12 years ago

In my opinion, changing
$value to array $value
in class.tx_linkvalidator_linktype_abstract.php is a break of the API. We extend this abstract class in DAM and can't have it compatible both to version 4.5 and 4.6 having two implementations - one for each version.
Was that intended?

Actions #4

Updated by Philipp Gampe over 12 years ago

Of course it would be possible to have to different tasks and register only on, depending on the TYPO3 version.

Although I agree this is not nice and as such reverted the changes here: https://review.typo3.org/#change,5580
Please have a look.

Actions #5

Updated by Xavier Perseguers about 12 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF