Bug #30244

Indexing of external documents with german "umlaut"s in filename does not work

Added by Online Now! GmbH about 8 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Jigal van Hemert
Category:
Indexed Search
Target version:
-
Start date:
2011-09-23
Due date:
% Done:

100%

TYPO3 Version:
4.5
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The indexing of external documents with special characters like german "umlaut"s does not work. The problem is similar to #21609. The absolute filename is going trough the function escapeshellarg(), which fails in this case if there is no proper locale set.

In issue #21609, there was a new config setting added ($TYPO3_CONF_VARS['SYS']['systemLocale']). This setting should be checked in the external parser class of indexed_search.

Related issues

Related to TYPO3 Core - Bug #55128: Fatal error in indexed_search FileContentParser Closed 2014-01-18

Associated revisions

Revision 9dbb81a4 (diff)
Added by Jigal van Hemert almost 6 years ago

[BUGFIX] Use system locale when indexing external documents

If paths or filenames of external documents contain utf-8 characters the
system locale must be used. Functions like escapeshellarg and basename are
locale aware.

Change-Id: I50a73a42d60de569c63e5ba27ad6a6a3a66fd6c8
Fixes: #30244
Releases: 4.5, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/5312
Reviewed-by: Markus Klein
Reviewed-by: Sebastian Fischer
Reviewed-by: Xavier Perseguers
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Revision b0291130 (diff)
Added by Jigal van Hemert over 5 years ago

[BUGFIX] Use system locale when indexing external documents

If paths or filenames of external documents contain utf-8 characters
the system locale must be used. Functions like escapeshellarg and
basename are locale aware.

Change-Id: I50a73a42d60de569c63e5ba27ad6a6a3a66fd6c8
Fixes: #30244
Releases: 4.5, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/26918
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision 50d36b86 (diff)
Added by Markus Klein over 5 years ago

[BUGFIX] Followup to "system locale when indexing"

A backport mistake happened letting the jpeg file extension
vanish. Undo that mistake.

Resolves: #30244
Releases: 6.1
Change-Id: I9e12485f03b5f4f468920e47b81308de2e0c6a4a
Reviewed-on: https://review.typo3.org/30897
Reviewed-by: Markus Klein
Tested-by: Markus Klein

History

#1 Updated by Jigal van Hemert about 8 years ago

  • Assignee set to Jigal van Hemert

#2 Updated by Mr. Hudson about 8 years ago

Patch set 1 of change I50a73a42d60de569c63e5ba27ad6a6a3a66fd6c8 has been pushed to the review server.
It is available at http://review.typo3.org/5312

#3 Updated by Mr. Hudson about 8 years ago

  • Status changed from New to Under Review

Patch set 2 of change I50a73a42d60de569c63e5ba27ad6a6a3a66fd6c8 has been pushed to the review server.
It is available at http://review.typo3.org/5312

#4 Updated by Gerrit Code Review about 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/5312

#5 Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/5312

#6 Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/5312

#7 Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/5312

#8 Updated by Gerrit Code Review over 7 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/5312

#9 Updated by Gerrit Code Review almost 7 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/5312

#10 Updated by Gerrit Code Review almost 7 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/5312

#11 Updated by Gerrit Code Review almost 7 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/5312

#12 Updated by Gerrit Code Review over 6 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/5312

#13 Updated by Gerrit Code Review over 6 years ago

Patch set 12 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/5312

#14 Updated by Gerrit Code Review about 6 years ago

Patch set 13 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/5312

#15 Updated by Gerrit Code Review about 6 years ago

Patch set 14 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/5312

#16 Updated by Jigal van Hemert almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#17 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26918

#18 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26918

#19 Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26919

#20 Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26918

#21 Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26920

#22 Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26918

#23 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26919

#24 Updated by Jigal van Hemert over 5 years ago

  • Status changed from Under Review to Resolved

#25 Updated by Gerrit Code Review over 5 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30897

#26 Updated by Markus Klein over 5 years ago

  • Status changed from Under Review to Resolved
  • Is Regression set to No

Merged for 6.1 and 6.2+

#27 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF