Project

General

Profile

Actions

Bug #31239

closed

compressor doesn't resolves files linked with domain

Added by Stefan Galinski about 13 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-10-24
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The compressor doesn't correctly handles files that are added with the e.g. pageRenderer method addJsFile with the domain applied.

Example:
http://localhost/site/myFile.js

Results in the following example warning:

PHP Warning: filemtime(): stat failed for /var/www/Intro/http://localhost/site/myFile.js in /var/www/typo3_src-git/t3lib/class.t3lib_compressor.php line 461

The attached patch is more or less a workaround, because this would increase the I/O burden on the server as it should not be needed to resolve and save the contents of local urls.


Files

urlReferences.patch (1.09 KB) urlReferences.patch Stefan Galinski, 2011-10-24 21:04

Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #32397: Page renderer provides files to compressor incorrectlyClosedDmitry Dulepov2011-12-08

Actions
Related to TYPO3 Core - Bug #34162: Merging CSS/JS files with absRefPrefix set causes PHP errorClosed2012-02-21

Actions
Has duplicate TYPO3 Core - Bug #32517: t3lib_compressor set local filename to remote uri for external resourcesClosed2011-12-13

Actions
Actions #1

Updated by Dmitry Dulepov almost 13 years ago

  • Assignee set to Dmitry Dulepov
  • Priority changed from Should have to Must have

There is more problems with this If config.absRefPrefix is set:

1. none of default styles are added to the output because path to the current site is prepended to the URL
2. even if the file is a local file, it always fetched using http from the current server [perfomance!!!]

The solution is very simple:
- do not add config.absRefPrefix (it is applied later to all URLs anyway)
- use is_file to check if the file is local and avoid fetching it using curl, etc

Actions #2

Updated by Alexander Opitz almost 10 years ago

  • Status changed from Accepted to Needs Feedback
  • Is Regression set to No

Hi,

does the problem still exists within newer versions of TYPO3 CMS (6.2.9)?

Actions #3

Updated by Dmitry Dulepov almost 10 years ago

  • Assignee deleted (Dmitry Dulepov)

No idea. It was a problem before, sadly not resolved there...

Actions #4

Updated by Alexander Opitz over 9 years ago

  • Status changed from Needs Feedback to Closed

No feedback to the actual releases within the last 90 days => closing this issue.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions

Also available in: Atom PDF