Bug #31762

Quotes in workspace title is displayed &qout; in workspaces tabs

Added by Marco Bresch over 8 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2011-11-11
Due date:
% Done:

100%

TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Because of double htmlspecialchar for the tabs. In all other places the workspace title is rendered correctly.

Toolbar, toolbarmenu and grid seems to be okay.

screen-capture-86.png View (43.3 KB) Marco Bresch, 2011-11-11 16:23

Associated revisions

Revision 62ad2114 (diff)
Added by Stefan Neufeind over 8 years ago

[BUGFIX] html-escaping of workspace-title too much

workspace-service provides title already escaped
by htmlspecialchars. To stay backward-compatible
this cannot be changed for releases <4.7 so
where fluid is used to output the second
escaping needs to be avoided.

Change-Id: I9ed7c3e907fd0f47950485b3a5bb6c81027f9868
Fixes: #31762
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/6753
Reviewed-by: Marco Bresch
Tested-by: Marco Bresch
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Revision 0bab0a14 (diff)
Added by Stefan Neufeind over 8 years ago

[BUGFIX] html-escaping of workspace-title too much

workspace-service provides title already escaped
by htmlspecialchars. To stay backward-compatible
this cannot be changed for releases <4.7 so
where fluid is used to output the second
escaping needs to be avoided.

Change-Id: I1d30663ec7195024078e8b35d71fca7d4d442150
Fixes: #31762
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/6789
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Revision 4d87c385 (diff)
Added by Stefan Neufeind over 8 years ago

[BUGFIX] html-escaping of workspace-title too much

Titles are escaped later during output.
Don't yet escape in the service composing
the list of workspaces.

Change-Id: Ieeeb909efef8dbfcbccfed85d5edad072b5b11b3
Fixes: #31762
Releases: 4.7
Reviewed-on: http://review.typo3.org/6664
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

History

#1 Updated by Stefan Neufeind over 8 years ago

  • Status changed from New to Accepted

Reproducible.

#2 Updated by Mr. Hudson over 8 years ago

Patch set 1 of change Ieeeb909efef8dbfcbccfed85d5edad072b5b11b3 has been pushed to the review server.
It is available at http://review.typo3.org/6664

#3 Updated by Mr. Hudson over 8 years ago

Patch set 2 of change Ieeeb909efef8dbfcbccfed85d5edad072b5b11b3 has been pushed to the review server.
It is available at http://review.typo3.org/6664

#4 Updated by Mr. Jenkins over 8 years ago

Patch set 1 of change I9ed7c3e907fd0f47950485b3a5bb6c81027f9868 has been pushed to the review server.
It is available at http://review.typo3.org/6753

#5 Updated by Mr. Jenkins over 8 years ago

Patch set 1 of change I1d30663ec7195024078e8b35d71fca7d4d442150 has been pushed to the review server.
It is available at http://review.typo3.org/6789

#6 Updated by Stefan Neufeind over 8 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:66d510f38f992c8e39d466e73678aa6acb1f33e0.

#7 Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6664

#8 Updated by Stefan Neufeind over 8 years ago

  • Status changed from Under Review to Resolved

Applied in changeset commit:ea2a39e9c7f0bf75bb4f660b00e4c0cd92eac81e.

#9 Updated by Michael Stucki over 6 years ago

  • Category set to Workspaces

#10 Updated by Michael Stucki over 6 years ago

  • Project changed from Workspaces & Versioning to TYPO3 Core
  • Category changed from Workspaces to Workspaces

#11 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF