Feature #32132

Making subjectField configurable with TS

Added by Josef F. Glatz (Old User) almost 8 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2011-11-28
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

It would be nice, if we have more possibilities as TYPO3 integrator to customize subject and making the field dynamic.
E.g. "Mail from ###subjectField###"

regards
jousch

patch.diff View (528 Bytes) Florian Scholz, 2012-02-07 11:29

form.txt View (1.42 KB) Florian Scholz, 2012-02-09 09:30

Associated revisions

Revision 363ed320 (diff)
Added by Florian Scholz over 7 years ago

[FEATURE] Add subjectField to Form Wizard TS

Change-Id: Ic3d28b9f641e1d20eb2fa99b0100def419cb17f1
Resolves: #32132
Releases: 4.7
Reviewed-on: http://review.typo3.org/8888
Reviewed-by: Markus Klein
Reviewed-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Philipp Gampe
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

History

#1 Updated by Florian Scholz over 7 years ago

Not sure where to put this patch, but I guess all we need here is adding subjectField to setSubject in tx_form_System_Postprocessor_Mail.
Attaching my very first patch to Typo3. Any additional hints are welcome :-)

Edit: I've figured out that I need to push my bits to review.typo3.org. Did that some minutes ago.

#2 Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8888

#3 Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8888

#4 Updated by Florian Scholz over 7 years ago

Philipp asked for a sample form TS for testing. I'm attaching my slightly modified TS, which was originally generated by the FormWizard.

The new thing is actually:

subjectField = subject

which can now refer to the input field "subject":
10 = TEXTLINE
10 {
    name = subject
    label {
        value = Betreff
    }
}

Before this patch you were only able to set "subject" which expects a string and not a field reference:
subject = Message via contact form on example.org

#5 Updated by Philipp Gampe over 7 years ago

@Florian Would you mind to add the documentation for this?
The right place would be: typo3/sysext/form/Documentation/Manual/en/manual.sxw

#6 Updated by Florian Scholz over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF