Bug #32159

Invalid SQL and bad code in tslib_fe

Added by Dmitry Dulepov over 10 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-11-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

tslibe_fe::determineId() contains invlid SQL statement (using "!=") and bad code (variable "$idQ", using hard-coded hidden/delete flags.


Related issues

Related to TYPO3 Core - Bug #25894: No preview of page if starttime is setRejectedSteffen Gebert2011-04-11

Actions
#1

Updated by Dmitry Dulepov over 10 years ago

Note that it this patch will also correctly show preview flag in case if the page has start/stop time set.

#2

Updated by Mr. Jenkins over 10 years ago

  • Status changed from New to Under Review

Patch set 1 of change If4c5db49a010331b5257ee33647cb23b31c5e020 has been pushed to the review server.
It is available at http://review.typo3.org/6974

#3

Updated by Mr. Jenkins over 10 years ago

Patch set 2 of change If4c5db49a010331b5257ee33647cb23b31c5e020 has been pushed to the review server.
It is available at http://review.typo3.org/6974

#4

Updated by Dmitry Dulepov over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#5

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/7409

#6

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/7409

#7

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/7410

#8

Updated by Dmitry Dulepov over 10 years ago

  • Status changed from Under Review to Resolved
#9

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9357

#10

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/7409

#11

Updated by Dmitry Dulepov over 10 years ago

  • Status changed from Under Review to Resolved
#12

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF