Bug #32253

Shortcut redirect doesn't respects the linkVars syntax

Added by Stefan Galinski over 7 years ago. Updated 8 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-12-01
Due date:
% Done:

100%

TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Currently the code that creates the redirect url for a shortcut page only respects the linkVars option as list of parameters without additional validation informations like it's documented in the TSRef1. Unfortunatly such paramaters are completely dropped and this leads to major problems on multilanguage sites with the new shortcut redirect feature.

[1] http://typo3.org/documentation/document-library/references/doc_core_tsref/4.1.0/view/7/3/

The file class.tslib_pagegen.php contains a valid implementation for this issue and should just moved to a nice API method as it does the same thing like the shortcut redirect functionality.

Associated revisions

Revision edd4844a (diff)
Added by Stefan Galinski over 7 years ago

[BUGFIX] Shortcut redirect ignores linkVars syntax

Currently the code that creates the redirect url for a shortcut
page only respects the linkVars option as list of parameters without
additional validation informations like it's documented in the
TSRef. Unfortunatly such paramaters are completely dropped and
this leads to major problems on multilanguage sites with the new
shortcut redirect feature.

Change-Id: I3966eedf284b06b7765f38ca07ea6cd7155babb3
Fixes: #32253
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/7015
Reviewed-by: Björn Pedersen
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch

Revision eeddbce9 (diff)
Added by Stefan Galinski over 7 years ago

[BUGFIX] Shortcut redirect ignores linkVars syntax

Currently the code that creates the redirect url for a shortcut
page only respects the linkVars option as list of parameters without
additional validation informations like it's documented in the
TSRef. Unfortunatly such paramaters are completely dropped and
this leads to major problems on multilanguage sites with the new
shortcut redirect feature.

Change-Id: I0abcaa56fdeb251c2333f4d807fbef3eeb0299a2
Fixes: #32253
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/8922
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski

History

#1 Updated by Mr. Jenkins over 7 years ago

  • Status changed from Accepted to Under Review

Patch set 1 of change I3966eedf284b06b7765f38ca07ea6cd7155babb3 has been pushed to the review server.
It is available at http://review.typo3.org/7015

#2 Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7015

#3 Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7015

#4 Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7015

#5 Updated by Michael Stucki over 7 years ago

  • Complexity set to easy

#6 Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/8922

#7 Updated by Stefan Galinski over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Johannes C. Schulz over 7 years ago

Hello

I have big trouble with this.
Before Update to 4.6.4 all worked fine, but now additional parameters are stripped from the URL and so authentication failes, trying to access a page.

the url:
http://www.DOMAIN.de/index.php?type=8800881&username=USERNAME&password=PASSWORD
the redirect goes to:
http://www.DOMAIN.de/homepage/?type=8800881

after applying the patched 31333 class.tslib_fe.php the pagetype is kept by the redirect, but username and password are dropped. So I applied this patch. But problem is still there.

I use realURL - maybe there is anything more to do?

#9 Updated by Stefan Galinski over 7 years ago

Did you tried to add this variables into the linkVars option? Preferably only on the shortcut page?

config.linkVars := addToList(username,password)

#10 Updated by Johannes C. Schulz over 7 years ago

That helped - thank you!

#11 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF