Project

General

Profile

Actions
Copy link

Bug #33316

closed

Syntax-Error: Two If-clauses with assign-operator instead of equal-operator in class.db_list.inc; Solution included!

Added by Clemens Riccabona almost 13 years ago. Updated almost 13 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2012-01-19
Due date:
% Done:

0%

Estimated time:
0.10 h
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

I don't know if the code is in any use, but due to some debugging I stumbled over a syntax-error in class.db_list.inc in at least TYPO3 4.5.9 and 4.5.10 at line 194 ff

// code snippet original begin
// this will hide records from display - it has nothing todo with user rights!!
if ($pidList = $GLOBALS['BE_USER']->getTSConfigVal('options.hideRecords.pages')) {
if ($pidList = $GLOBALS['TYPO3_DB']->cleanIntList($pidList)) {
$this->perms_clause .= ' AND pages.uid NOT IN ('.$pidList.')';
}
}
// code snippet original end

This should be changed to this I think:


// code snippet corrected begin
// this will hide records from display - it has nothing todo with user rights!!
if ($pidList $GLOBALS['BE_USER']->getTSConfigVal('options.hideRecords.pages')) {
if ($pidList $GLOBALS['TYPO3_DB']->cleanIntList($pidList)) {
$this->perms_clause .= ' AND pages.uid NOT IN ('.$pidList.')';
}
}
// code snippet corrected end

Actions
Copy link

Also available in: Atom PDF