Project

General

Profile

Actions
Copy link

Bug #33858

closed

Toolbar Item

Added by Felix Kopp almost 13 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2012-02-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Put the Workspace icon into the link within the toolbar item.

Actions
Copy link
 #1

Updated by Felix Kopp almost 13 years ago

Classes/ExtDirect/WorkspaceSelectorToolbarItem.php

$workspaceMenu[] = '<li' . $selected . '>' . 
                    ' <a href="backend.php?changeWorkspace=' .
                    intval($workspaceId) . '" id="ws-' . intval($workspaceId) .
                    '" class="ws">' . $icon . $label . '</a></li>';

instead of

$workspaceMenu[] = '<li' . $selected . '>' . $icon .
                    ' <a href="backend.php?changeWorkspace=' .
                    intval($workspaceId) . '" id="ws-' . intval($workspaceId) .
                    '" class="ws">' . $label . '</a></li>';

I will supply a reviewable patchset

Actions
Copy link
 #2

Updated by Philipp Gampe almost 13 years ago

Ping ... still working? Need something to review ;)

Actions
Copy link
 #3

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10488

Actions
Copy link
 #4

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10488

Actions
Copy link
 #5

Updated by Gerrit Code Review over 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10488

Actions
Copy link
 #6

Updated by Gerrit Code Review over 12 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10488

Actions
Copy link
 #7

Updated by Felix Kopp over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:d8161b796f73d856f70e1f8af6d3d7b0d6c04edd.

Actions
Copy link
 #8

Updated by Gerrit Code Review over 12 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch workspaces_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13887

Actions
Copy link
 #9

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch 4.6 has been pushed to the review server.
It is available at http://review.typo3.org/13889

Actions
Copy link
 #10

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch 4.5 has been pushed to the review server.
It is available at http://review.typo3.org/13890

Actions
Copy link
 #11

Updated by Felix Kopp over 12 years ago

  • Status changed from Under Review to Resolved

Applied in changeset commit:d75d92bf5d4411008dab045297729a34ff991711.

Actions
Copy link
 #12

Updated by Michael Stucki almost 11 years ago

  • Category set to Workspaces
Actions
Copy link
 #13

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions
Copy link
 #14

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF