Bug #34092

Task #31461: The Big Cleanup 4.7

Task #33743: Strictly only allow UTF-8

Remove all references to forceCharset setting

Added by Steffen Ritter about 8 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Category:
Code Cleanup
Target version:
Start date:
2012-02-19
Due date:
2012-02-19
% Done:

100%

Estimated time:
1.00 h
TYPO3 Version:
4.7
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

The forceCharset is deprecated since 4.5 and is to be removed in 4.7
Remove all references to it. If behaviour is in question, change as it would have been set to 'utf-8' as it is like this since 4.5.


Related issues

Related to TYPO3 Core - Bug #34369: Fix setDBinit regression Closed 2012-02-27 2012-02-27
Related to TYPO3 Core - Bug #35901: Failing charset related test in page renderer Closed 2012-04-12
Related to TYPO3 Core - Bug #49336: Remove forceCharset handling Closed 2013-06-21
Duplicates TYPO3 Core - Bug #33793: Deprecated config options in install tool Closed 2012-02-08
Precedes TYPO3 Core - Task #34094: Change fallbacks to iso-8859-1 to utf-8 Closed 2012-02-20 2012-02-20

Associated revisions

Revision 8f5456d8 (diff)
Added by Steffen Ritter about 8 years ago

[CLEANUP][CONF!!!] Remove forceCharset option and references

In TYPO3 4.5 the forceCharset and setDBinit options have been
deprecated. "forceCharset" was set to be removed in 4.7.

This ChangeSet removes the config option from the install tool
and all references within core to this variable.

If behaviour had been in question, the code has been adapted
to behave like the variable had been set to utf-8 and therefore
like the behaviour had been since 4.5.

Change-Id: Ic8fa9385b59eb127271c4f1a0902bbe8f3ee5499
Resolves: #34092
Releases: 4.7
Reviewed-on: http://review.typo3.org/9099
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki

Revision baddedde (diff)
Added by Christian Kuhn almost 8 years ago

[BUGFIX] Failing charset related test in page renderer

With issue #34092 the charset conversion code was removed from
the core. Test isInlineLanguageLabelDeliveredWithNonUTF8 fails
now and can be removed as obsolete.

Change-Id: I12e03ce182cda6d6f4b4a6da650f0c17327188a5
Resolves: #35901
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/10336
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision caec8202 (diff)
Added by Christian Kuhn almost 8 years ago

[BUGFIX] Failing charset related test in page renderer

With issue #34092 the charset conversion code was removed from
the core. Test isInlineLanguageLabelDeliveredWithNonUTF8 fails
now and can be removed as obsolete.

Change-Id: If85e3daa2211a6e1751d06423c624fd957f60c87
Resolves: #35901
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/10337
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 2332335a (diff)
Added by Christian Kuhn almost 7 years ago

[TASK] Remove last bits of forceCharset handling

Core version 4.5 introduced UTF8 only for charset conversion, and
accepted a fallback under special circumstances. The fallback was
removed with 4.7.
This setting is now finally fully removed from the configuration
and not taken into account anymore.

Change-Id: Ic347c3decb985ec63eb499d5d75827fc7f1f7a8a
Resolves: #49336
Related: #49299
Related: #34092
Releases: 6.2
Reviewed-on: https://review.typo3.org/21584
Reviewed-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1 Updated by Steffen Ritter about 8 years ago

The exchange of all "iso-8859-1" fallbacks to "utf-8" will be handled in a separate ticket

#2 Updated by Gerrit Code Review about 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9099

#3 Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9099

#4 Updated by Gerrit Code Review about 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9099

#5 Updated by Gerrit Code Review about 8 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9099

#6 Updated by Gerrit Code Review about 8 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9099

#7 Updated by Gerrit Code Review about 8 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9099

#8 Updated by Gerrit Code Review about 8 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9099

#9 Updated by Steffen Ritter about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Riccardo De Contardi over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF