Actions
Bug #34557
closedMissing backticks in t3lib_install_Sql->getUpdateSuggestions
Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2012-03-06
Due date:
% Done:
0%
Estimated time:
TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:
Description
Is there any reason not to add backticks in the field definitions? If I try to add a column named "order" or any other reserved word it won't work without backticks.
The attached patch adds backticks to all field and table names in this method, except in the ADD KEY field list like in:
ALTER TABLE `sys_log` ADD KEY user_auth (type,action,tstamp);
Files
Updated by Christian Jul Jensen over 12 years ago
Thanks for providing the patch, would be great if you can submit it for review. Check out the guides here: http://typo3.org/development/bug-fixing/resolving-bugs/
Updated by Nico de Haen over 12 years ago
Ok, I will submit it to gerrit if you think it's a useful patch.
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9551
Updated by Alexander Opitz about 11 years ago
- Status changed from Under Review to Closed
In favor of #35253
Actions