Task #34629
closed
Clean up phpDoc comments in class template
100%
Description
In analogy to #28087 I want to clean up the template class (typo3/template.php) this time. Clean phpDoc comments are important to make the API understandable to Users and IDEs.
So I made a patch doing mostly:
- Provide correct parameter names in phpDoc
- Provide correct data types in phpDoc
- CGLify phpDoc (remove tabs)
- CGLify method signatures (the first line of the method)
- Corrected a few minor very obvious flaws ("$size = $size;" was my favorite)
Note on green bar feeling: After the patch the class is not green yet, but it has improved a lot. I'd like to tackle a few more flaws when this obvious changes are through.
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9450
Updated by Gerrit Code Review over 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9450
Updated by Gerrit Code Review over 12 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9450
Updated by Gerrit Code Review over 12 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9450
Updated by Sebastian Michaelsen over 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a31b94a0bdb7ffe57824bdbc6f10ab0256bf6fa0.
Updated by