Task #34771

Add missing sql_free_result in alt_doc.php

Added by Wouter Wolters over 10 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-03-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

In the file alt_doc.php there is the function editRegularContentFromId.
This function does not properly free the resource.

if ($GLOBALS['TYPO3_DB']->sql_num_rows($res))    {
    $ecUids=array();
    while($ecRec = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res))    {
        $ecUids[]=$ecRec['uid'];
    }
    $this->editconf['tt_content'][implode(',',$ecUids)]='edit';
}

If accepted I can provide a patch for it:)

#1

Updated by Oliver Hader over 10 years ago

  • Status changed from New to Accepted
  • PHP Version set to 5.3

Go ahead :)
Fixing hanging record sets is always good...

#2

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9757

#3

Updated by Wouter Wolters over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#4

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9865

#5

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9866

#6

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/9867

#7

Updated by Wouter Wolters over 10 years ago

  • Status changed from Under Review to Resolved
#8

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF