Bug #35714

inDocStyles_TBEstyle inserted twice

Added by Simon Schaufelberger over 7 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-04-05
Due date:
% Done:

0%

TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

setting some styles with:

$GLOBALS['TBE_STYLES']['inDocStyles_TBEstyle'] = 'body#typo3-index-php #t3-login-form, body#typo3-index-php #t3-footer { margin-left: auto; margin-right: auto; }

they are now twice in the header.

A quick search in typo3/template.php but did not find the reason for it on first sight.


Related issues

Duplicates TYPO3 Core - Bug #55458: DocumentTemplate class inserts inDocStyles twice Closed 2014-01-30

History

#1 Updated by Georg Ringer over 7 years ago

  • Status changed from New to Needs Feedback

cant reproduce on master, can you remove for testing all used extensions=?

#2 Updated by Simon Schaufelberger over 7 years ago

Use Typo3 4.5, login in the backend (showing the source of backend.php) and then you will see:

<style type="text/css">
/*<![CDATA[*/
<!-- 
/*inDocStyles*/

body#typo3-index-php #t3-login-form, body#typo3-index-php #t3-footer { margin-left: auto; margin-right: auto; }

body#typo3-index-php #t3-login-form, body#typo3-index-php #t3-footer { margin-left: auto; margin-right: auto; }

-->
/*]]>*/
</style>

#3 Updated by Georg Ringer over 7 years ago

  • Status changed from Needs Feedback to Accepted

also in 6.0 after being logged in, thx

#4 Updated by Georg Ringer over 7 years ago

problem is in template.php:

styles are added twice:

1st in function docstyle

$this->pageRenderer->addCssInlineBlock('inDocStyles', $inDocStyles . LF . '/*###POSTCSSMARKER###*/');

and 2nd in function insertStylesAndJS

$this->inDocStylesArray[] = $this->inDocStyles;
        $styles = LF.implode(LF, $this->inDocStylesArray);
        $content = str_replace('/*###POSTCSSMARKER###*/',$styles,$content);

#5 Updated by Simon Schaufelberger over 7 years ago

@Georg: shall i make a patch or can you do that please? i don't know which one is better to remove. i guess you have more the view about possible side effects.

#6 Updated by Simon Schaufelberger about 7 years ago

status?

#7 Updated by Noel Bossart almost 6 years ago

Simon Schaufelberger wrote:

status?

Still present in latest 4.7

#8 Updated by Stefan Neufeind almost 6 years ago

  • Status changed from Accepted to Closed
  • Is Regression set to No

fixed with #55458 in master (to become 6.2). Backports to 6.1 and 4.5 under discussion. Not really a "priority fix" so won't land in 4.7/6.0, sorry.

Also available in: Atom PDF