Bug #36316

RTE: Importing google webfonts breaks style sheet parsing

Added by Robert Vock over 10 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
Start date:
2012-04-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

The rte does not show any custom classes, if your rte.css imports google webfonts:

rte.css

@charset "UTF-8";
@import "http://fonts.googleapis.com/css?family=Quattrocento+Sans:400,700,400italic,700italic";
p.teaser {
font-weight:bold;
}

pageTS is configured with this teaser class, but the class does not show up in the style drop down.
Removing the @import solves this issue (the class shows up correctly).

Digging into the code, I found the bug in sysext/rtehtmlarea/htmlarea/htmlarea.js:
When parsing the rules, it only checks if it is an import rule and uses the cssRules of that stylesheet:
Line 3761:

if (cssRules[rule].styleSheet) {
    this.parseRules(cssRules[rule].styleSheet.cssRules);
}

The correct check would be:

if (cssRules[rule].styleSheet && cssRules[rule].styleSheet.cssRules) {
    this.parseRules(cssRules[rule].styleSheet.cssRules);
}

In the case of the google web fonts cssRules is null and the check for cssRules.length fails.


Related issues

Related to TYPO3 Core - Bug #49648: RTE: Importing google webfonts breaks style sheet parsing in FirefoxClosedStanislas Rolland2013-07-03

Actions
#1

Updated by Stanislas Rolland about 10 years ago

  • Subject changed from htmlarea: Custom classes not working when importing google webfonts to RTE: Importing google webfonts breaks style sheet parsing
  • Assignee set to Stanislas Rolland
  • Target version set to 4.5.18
#2

Updated by Gerrit Code Review about 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12646

#3

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12681

#4

Updated by Stanislas Rolland about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#5

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12682

#6

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12683

#7

Updated by Stanislas Rolland about 10 years ago

  • Status changed from Under Review to Resolved
#8

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13194

#9

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13298

#10

Updated by Stanislas Rolland almost 10 years ago

Gerrit Code Review wrote:

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13298

This patch set does not exist.

#11

Updated by Stanislas Rolland almost 10 years ago

Gerrit Code Review wrote:

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13298

This patch set does not exist.

#12

Updated by Stanislas Rolland almost 10 years ago

Gerrit Code Review wrote:

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13194

This patch set does not exist.

#13

Updated by Stanislas Rolland almost 10 years ago

Gerrit Code Review wrote:

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13298

This patch set does not exist.

#14

Updated by Stanislas Rolland almost 10 years ago

Gerrit Code Review wrote:

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13194

This patch set does not exist.

#15

Updated by Stanislas Rolland almost 10 years ago

  • Status changed from Under Review to Resolved
#16

Updated by Riccardo De Contardi almost 5 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF